You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/12 07:07:52 UTC

[GitHub] [cloudstack] rhtyd opened a new pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

rhtyd opened a new pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300


   This adds support for VMware 7.0 with a jar dependency and sql upgrade path. The jar dependency has been added to support noredist pkging here:
   https://github.com/rhtyd/cloudstack-nonoss/blob/master/install-non-oss.sh#L37
   
   Fixes #4441
   Fixes #4423
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-779466417


   <b>Trillian test result (tid-3542)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32380 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3542-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 10.41 | test_scale_vm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-814071008


   @nvazquez can you fix the merge conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778020336


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816486678


   @nvazquez please fix conflicts and re-run a round of smoketests against vmware7 and vmware 6.7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816747164


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819491779


   @nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819493468


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-712727486


   Kicked tests against vCenter 7 based env.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez removed a comment on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819479797


   @blueorangutan help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-786505381


   Let me regression testing
   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-752313782


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2520


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-687650152


   @blueorangutan test centos7 vmware-67u3
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-764398946


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-752308010


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-779494033


   <b>Trillian test result (tid-3543)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38140 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3543-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r582553827



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,10 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0

Review comment:
       @sureshanaparti yes - added on the last commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl, VirtualMachine vm, HostVO hos
         return sb.toString();
     }
 
+    /**
+     * Sets the URL to establish a VNC over websocket connection
+     */
+    private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam param) {
+        String ticket = acquireVncTicketForVmwareVm(vm);

Review comment:
       _ acquireVncTicketForVmwareVm()_ returns null, in case of any errors/exceptions, check for the same ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-687650395


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785632115


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819479797


   @blueorangutan help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-814947794


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819530775


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r590999282



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 330, now(), 0);
+
+-- Add support for darwin19_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (331, UUID(), 7, 'macOS 10.15 (64 bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 331, now(), 0);
+
+-- Add support for debian11_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (332, UUID(), 2, 'Debian GNU/Linux 11 (64-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11_64Guest', 332, now(), 0);
+
+-- Add support for debian11Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (333, UUID(), 2, 'Debian GNU/Linux 11 (32-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11Guest', 333, now(), 0);
+
+-- Add support for vmkernel7Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (334, UUID(), 7, 'vmkernel7Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'vmkernel7Guest', 334, now(), 0);
+
+-- Add support for windows2019srv_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'windows2019srv_64Guest', 276, now(), 0);
+
+
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);

Review comment:
       or is it the version returned by vcenter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-777258653


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785818336


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580202141



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,10 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0

Review comment:
       @nvazquez any new OS supported with 7.0 / 7.0.1.0 to be added to guest os mappings




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785792930


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2825


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-764398946






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778569061


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2698


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819542529


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-814927956


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-779191510


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819541536


   @blueorangutan test centos7 vmware-70u1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r561675920



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -500,6 +526,20 @@ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm, HostVO
         return sb.toString();
     }
 
+    /**
+     * Generates an extra parameter to be passed to noVNC server to connect to WebSocket exposed on Vmware hosts.
+     * This method has been introduced as Vmware 7 has deprecated the previous VNC approach to connect to VMs console.
+     * Please check: https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+     */
+    private String generateExtraNoVNCParameter(ConsoleProxyClientParam param) {
+        String extraParam = null;
+        if (StringUtils.isNotBlank(param.getTicketAcquired())) {
+            extraParam = "wss://" + param.getClientHostAddress() + ":443/ticket/" + param.getTicketAcquired();

Review comment:
       @nvazquez declare a constant for port 443 in some common class (may be ConsoleProxyManager), and use it across.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819508880


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713493812


   Marvin tests with this PR and vCenter 7.0 with CentOS7 mgmt server but two 6.7u3 ESXi hosts:
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Error` | 0.15 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.07 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.07 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
   test_01_add_primary_storage_disabled_host | `Error` | 0.51 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.18 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.31 | test_primary_storage.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.21 | test_snapshots.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.28 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.20 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.20 | test_templates.py
   test_01_volume_usage | `Error` | 11.57 | test_usage.py
   test_11_migrate_vm | `Error` | 50.32 | test_vm_life_cycle.py
   test_01_create_volume | `Error` | 134.77 | test_volumes.py
   test_02_attach_volume | `Error` | 44.96 | test_volumes.py
   test_03_download_attached_volume | `Error` | 1.10 | test_volumes.py
   test_04_delete_attached_volume | `Error` | 1.11 | test_volumes.py
   test_05_detach_volume | `Error` | 1.10 | test_volumes.py
   test_06_download_detached_volume | `Error` | 1.11 | test_volumes.py
   test_07_resize_fail | `Error` | 2.28 | test_volumes.py
   test_08_resize_volume | `Error` | 1.11 | test_volumes.py
   test_09_delete_detached_volume | `Error` | 12.63 | test_volumes.py
   test_11_attach_volume_with_unstarted_vm | `Error` | 2.39 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 19.09 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 443.14 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3790.27 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3790.31 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 0.01 | test_vpc_redundant.py
   ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.02 | test_vpc_redundant.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl, VirtualMachine vm, HostVO hos
         return sb.toString();
     }
 
+    /**
+     * Sets the URL to establish a VNC over websocket connection
+     */
+    private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam param) {
+        String ticket = acquireVncTicketForVmwareVm(vm);

Review comment:
       _ acquireVncTicketForVmwareVm()_ returns null, in case of any errors/expections, check for the same ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez removed a comment on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819530378






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713525950


   @blueorangutan test centos7 vmware-67u3
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819952424


   @rhtyd @vladimirpetrov Vmware 7.0 support was introduced into Trillian and the last tests were executed on it, few errors which seem unrelated to this PR. Please advise if we are ready to merge it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785637903


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 41


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl, VirtualMachine vm, HostVO hos
         return sb.toString();
     }
 
+    /**
+     * Sets the URL to establish a VNC over websocket connection
+     */
+    private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam param) {
+        String ticket = acquireVncTicketForVmwareVm(vm);

Review comment:
       _acquireVncTicketForVmwareVm()_ returns null, in case of any errors/exceptions, check for the same ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819512621


   @blueorangutan test centos7 vmware-70u1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819513286


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-814927074


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r585219869



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 330, now(), 0);
+
+-- Add support for darwin19_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (331, UUID(), 7, 'macOS 10.15 (64 bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 331, now(), 0);
+
+-- Add support for debian11_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (332, UUID(), 2, 'Debian GNU/Linux 11 (64-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11_64Guest', 332, now(), 0);
+
+-- Add support for debian11Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (333, UUID(), 2, 'Debian GNU/Linux 11 (32-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11Guest', 333, now(), 0);
+
+-- Add support for vmkernel7Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (334, UUID(), 7, 'vmkernel7Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'vmkernel7Guest', 334, now(), 0);
+
+-- Add support for windows2019srv_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'windows2019srv_64Guest', 276, now(), 0);
+
+
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);

Review comment:
       @rhtyd yes - hosts on 7.0 u1 report the version 7.0.1.0




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-799967912


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-730872855


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd closed pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816761477


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-817077173


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-714159838


   <b>Trillian test result (tid-3035)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46517 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3035-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 83 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 249.79 | test_kubernetes_clusters.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.15 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.14 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.14 | test_templates.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r561675920



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -500,6 +526,20 @@ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm, HostVO
         return sb.toString();
     }
 
+    /**
+     * Generates an extra parameter to be passed to noVNC server to connect to WebSocket exposed on Vmware hosts.
+     * This method has been introduced as Vmware 7 has deprecated the previous VNC approach to connect to VMs console.
+     * Please check: https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+     */
+    private String generateExtraNoVNCParameter(ConsoleProxyClientParam param) {
+        String extraParam = null;
+        if (StringUtils.isNotBlank(param.getTicketAcquired())) {
+            extraParam = "wss://" + param.getClientHostAddress() + ":443/ticket/" + param.getTicketAcquired();

Review comment:
       @nvazquez declare a constant for port 443 in some common class (may be ConsoleProxyManager), and use it across.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-786871743


   <b>Trillian test result (tid-3622)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39141 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3622-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 775.66 | test_kubernetes_clusters.py
   test_03_migrate_detached_volume | `Error` | 72.70 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 43.50 | test_vm_life_cycle.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-764481877


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2561


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd removed a comment on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-687650152


   @blueorangutan test centos7 vmware-67u3
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819474076


   @nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713498864


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r590497452



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());

Review comment:
       This is not necessary




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819473593


   @blueorangutan help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez edited a comment on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez edited a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-731493405


   Run tests against vCenter 7.0 with 2 ESXi hosts on version 7.0.1:
   
   ````
   [root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat test-summary.txt 
   82 look ok, 4 have errors
   ````
   
   ````
   [root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat smoketests-summary.txt 
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAffinityGroup | `Failure` | 168.65 | test_affinity_groups.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 786.00 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 85.78 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 96.18 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.11 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.10 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.21 | test_kubernetes_clusters.py
   test_03_migration_options_storage_tags | `Error` | 0.44 | test_primary_storage.py
   test_01_migrate_VM_and_root_volume | `Error` | 112.09 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 60.85 | test_vm_life_cycle.py
   test_03_migrate_detached_volume | `Error` | 73.09 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 62.04 | test_vm_life_cycle.py
   ````


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-800192660


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 136


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819530378


   @blueorangutan test centos7 vmware-70u1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-730911979


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2411


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819480410


   @nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-731493405


   Run tests against vCenter 7.0 with 2 ESXi hosts on version 7.0.1:
   
   ````
   [root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat test-summary.txt 
   82 look ok, 4 have errors
   [root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat smoketests-summary.txt 
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAffinityGroup | `Failure` | 168.65 | test_affinity_groups.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 786.00 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 85.78 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 96.18 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.11 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.10 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.21 | test_kubernetes_clusters.py
   test_03_migration_options_storage_tags | `Error` | 0.44 | test_primary_storage.py
   test_01_migrate_VM_and_root_volume | `Error` | 112.09 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 60.85 | test_vm_life_cycle.py
   test_03_migrate_detached_volume | `Error` | 73.09 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 62.04 | test_vm_life_cycle.py
   ````


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819480410


   @nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785631678


   Thanks @sureshanaparti @rhtyd - comments addressed
   
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r590999125



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 330, now(), 0);
+
+-- Add support for darwin19_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (331, UUID(), 7, 'macOS 10.15 (64 bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 331, now(), 0);
+
+-- Add support for debian11_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (332, UUID(), 2, 'Debian GNU/Linux 11 (64-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11_64Guest', 332, now(), 0);
+
+-- Add support for debian11Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (333, UUID(), 2, 'Debian GNU/Linux 11 (32-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11Guest', 333, now(), 0);
+
+-- Add support for vmkernel7Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (334, UUID(), 7, 'vmkernel7Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'vmkernel7Guest', 334, now(), 0);
+
+-- Add support for windows2019srv_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'windows2019srv_64Guest', 276, now(), 0);
+
+
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);

Review comment:
       Should the version be just `7.0.1`? 
   I see this on esxi - `/resourceGroups/version = "7.0.1"`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713521553


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2250


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-799979099


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 130


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778732825


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778565910


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-817077285


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-689039222


   <b>Trillian test result (tid-2694)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 77101 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t2694-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 78 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 970.19 | test_kubernetes_supported_versions.py
   test_07_reboot_ssvm | `Failure` | 41.90 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 42.89 | test_ssvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-687650395


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580217264



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl, VirtualMachine vm, HostVO hos
         return sb.toString();
     }
 
+    /**
+     * Sets the URL to establish a VNC over websocket connection
+     */
+    private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam param) {
+        String ticket = acquireVncTicketForVmwareVm(vm);
+        String wsUrl = composeWebsocketUrlForVmwareVm(ticket, param);
+        param.setWebsocketUrl(wsUrl);
+    }
+
+    /**
+     * Format expected: wss://<ESXi_HOST_IP>:443/ticket/<TICKET_ID>
+     */
+    private String composeWebsocketUrlForVmwareVm(String ticket, ConsoleProxyClientParam param) {
+        param.setClientHostPort(443);
+        return String.format("wss://%s:%s/ticket/%s", param.getClientHostAddress(), param.getClientHostPort(), ticket);
+    }
+
+    /**
+     * Acquires a ticket to be used for console proxy as described in 'Removal of VNC Server from ESXi' on:
+     * https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+     */
+    private String acquireVncTicketForVmwareVm(VirtualMachine vm) {
+        try {
+            s_logger.info("Acquiring VNC ticket for VM = " + vm.getHostName());
+            GetVmVncTicketCommand cmd = new GetVmVncTicketCommand(vm.getInstanceName());
+            Answer answer = agentManager.send(vm.getHostId(), cmd);
+            GetVmVncTicketAnswer ans = (GetVmVncTicketAnswer) answer;

Review comment:
       better check for the answer result before continuing with the ticket, as the ticket can be null in case of error scenarios 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-684645233


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-779190874


   @blueorangutan test matrix


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r583422917



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 330, now(), 0);
+
+-- Add support for darwin19_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (331, UUID(), 7, 'macOS 10.15 (64 bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 331, now(), 0);
+
+-- Add support for debian11_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (332, UUID(), 2, 'Debian GNU/Linux 11 (64-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11_64Guest', 332, now(), 0);
+
+-- Add support for debian11Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (333, UUID(), 2, 'Debian GNU/Linux 11 (32-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11Guest', 333, now(), 0);
+
+-- Add support for vmkernel7Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (334, UUID(), 7, 'vmkernel7Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'vmkernel7Guest', 334, now(), 0);
+
+-- Add support for windows2019srv_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'windows2019srv_64Guest', 276, now(), 0);
+
+
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);

Review comment:
       @nvazquez does CloudStack/VMware plugin make a difference between 7.0 and 7.0.1.0 from the DB?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r594875231



##########
File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java
##########
@@ -121,22 +126,33 @@ public void run() {
                         s_logger.error("Unexpected exception", e);
                     }
 
-                    String ver = client.handshake();
-                    session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0, ver.length()));
+                    String ver;
+                    byte[] b;
+                    if (!client.isVncOverWebSocketConnection()) {
+                        ver = client.handshake();
+                        session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0, ver.length()));
 
-                    byte[] b = client.authenticate(getClientHostPassword());
-                    session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+                        b = client.authenticate(getClientHostPassword());
+                        session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+                    }
 
                     int readBytes;
                     while (connectionAlive) {
-                        b = new byte[100];
-                        readBytes = client.read(b);
-                        if (readBytes == -1) {
-                            break;
-                        }
-                        if (readBytes > 0) {
-                            session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, readBytes));
-                            updateFrontEndActivityTime();
+                        if (client.isVncOverWebSocketConnection()) {
+                            if (client.isVncOverWebSocketConnectionOpen()) {
+                                updateFrontEndActivityTime();
+                            }
+                            connectionAlive = client.isVncOverWebSocketConnectionAlive();
+                        } else {
+                            b = new byte[100];
+                            readBytes = client.read(b);
+                            if (readBytes == -1) {
+                                break;
+                            }
+                            if (readBytes > 0) {
+                                session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, readBytes));
+                                updateFrontEndActivityTime();
+                            }

Review comment:
       Done, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-795838137


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 80


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r582553745



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,10 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
 
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0.1.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0';

Review comment:
       @rhtyd yes - hosts on 7.0 u1 report the version 7.0.1.0




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-800175697


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580215605



##########
File path: core/src/main/java/com/cloud/agent/api/GetVmVncTicketAnswer.java
##########
@@ -0,0 +1,32 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.api;
+
+public class GetVmVncTicketAnswer extends Answer {
+

Review comment:
       cmd result (success / failed - with the reason) in the answer?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-779547526


   <b>Trillian test result (tid-3544)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50317 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3544-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 1451.71 | test_kubernetes_clusters.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785817708


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-688491320


   @blueorangutan test centos7 vmware-67u3
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713526542


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778565794


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819530775


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-820180905


   LGTM, @vladimirpetrov are you lgtm on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-752307868


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-684646159


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r528060974



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -19,6 +19,10 @@
 -- Schema upgrade from 4.14.0.0 to 4.15.0.0
 --;
 
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+

Review comment:
       :+1: yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd closed pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-713498190


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778732712


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819494188


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r594871650



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());

Review comment:
       Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785637503


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r559985294



##########
File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
##########
@@ -537,10 +545,14 @@ public static ConsoleProxyNoVncClient getNoVncViewer(ConsoleProxyClientParam par
             Session session) throws AuthenticationException {
         boolean reportLoadChange = false;
         String clientKey = param.getClientMapKey();
+        String ticketAcquired = param.getTicketAcquired();
+        if (StringUtils.isNotBlank(ticketAcquired)) {
+            s_logger.info(">>>>> NO VNC Viewer received ticket acquired: " + param.getTicketAcquired());
+        }
         synchronized (connectionMap) {
             ConsoleProxyClient viewer = connectionMap.get(clientKey);
             if (viewer == null || viewer.getClass() != ConsoleProxyNoVncClient.class) {
-                authenticationExternally(param);
+                //authenticationExternally(param);

Review comment:
       remove the comment if not required here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-684727916


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1865


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-730872382


   Rebased master - @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-685454589






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-685448234


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778603639


   @blueorangutan help


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-795827418


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-764398604


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778736034


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2705


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-777258906


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r585550677



##########
File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java
##########
@@ -121,22 +126,33 @@ public void run() {
                         s_logger.error("Unexpected exception", e);
                     }
 
-                    String ver = client.handshake();
-                    session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0, ver.length()));
+                    String ver;
+                    byte[] b;
+                    if (!client.isVncOverWebSocketConnection()) {
+                        ver = client.handshake();
+                        session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0, ver.length()));
 
-                    byte[] b = client.authenticate(getClientHostPassword());
-                    session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+                        b = client.authenticate(getClientHostPassword());
+                        session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+                    }
 
                     int readBytes;
                     while (connectionAlive) {
-                        b = new byte[100];
-                        readBytes = client.read(b);
-                        if (readBytes == -1) {
-                            break;
-                        }
-                        if (readBytes > 0) {
-                            session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, readBytes));
-                            updateFrontEndActivityTime();
+                        if (client.isVncOverWebSocketConnection()) {
+                            if (client.isVncOverWebSocketConnectionOpen()) {
+                                updateFrontEndActivityTime();
+                            }
+                            connectionAlive = client.isVncOverWebSocketConnectionAlive();
+                        } else {
+                            b = new byte[100];
+                            readBytes = client.read(b);
+                            if (readBytes == -1) {
+                                break;
+                            }
+                            if (readBytes > 0) {
+                                session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, readBytes));
+                                updateFrontEndActivityTime();
+                            }

Review comment:
       could you disect `initlient()` into multiple methods, it is sneakily growing too complex.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580219285



##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl, VirtualMachine vm, HostVO hos
         return sb.toString();
     }
 
+    /**
+     * Sets the URL to establish a VNC over websocket connection
+     */
+    private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam param) {
+        String ticket = acquireVncTicketForVmwareVm(vm);
+        String wsUrl = composeWebsocketUrlForVmwareVm(ticket, param);
+        param.setWebsocketUrl(wsUrl);
+    }
+
+    /**
+     * Format expected: wss://<ESXi_HOST_IP>:443/ticket/<TICKET_ID>
+     */
+    private String composeWebsocketUrlForVmwareVm(String ticket, ConsoleProxyClientParam param) {
+        param.setClientHostPort(443);
+        return String.format("wss://%s:%s/ticket/%s", param.getClientHostAddress(), param.getClientHostPort(), ticket);
+    }
+
+    /**
+     * Acquires a ticket to be used for console proxy as described in 'Removal of VNC Server from ESXi' on:
+     * https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+     */
+    private String acquireVncTicketForVmwareVm(VirtualMachine vm) {
+        try {
+            s_logger.info("Acquiring VNC ticket for VM = " + vm.getHostName());
+            GetVmVncTicketCommand cmd = new GetVmVncTicketCommand(vm.getInstanceName());
+            Answer answer = agentManager.send(vm.getHostId(), cmd);
+            GetVmVncTicketAnswer ans = (GetVmVncTicketAnswer) answer;
+            return ans.getTicket();
+        } catch (AgentUnavailableException | OperationTimedoutException e) {
+            s_logger.error("Error acquiring ticket", e);
+            return null;

Review comment:
       in case of failure, better send the error msg with result as fail in the answer, and process accordingly on the receiving side.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580209328



##########
File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java
##########
@@ -62,6 +69,27 @@ public void connectTo(String host, int port) throws UnknownHostException, IOExce
         setStreams();
     }
 
+    public void connectToWebSocket(String websocketUrl, Session session) throws URISyntaxException {
+        webSocketReverseProxy = new WebSocketReverseProxy(new URI(websocketUrl), session);
+        webSocketReverseProxy.connect();
+    }
+
+    public boolean isVncOverWebSocketConnection() {
+        return webSocketReverseProxy != null;
+    }
+

Review comment:
       Non websocket connections, will cause NPE for the below methods. Either add a comment here to use these methods for _isVncOverWebSocketConnection()_ true, or explicitly add a check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan removed a comment on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819513286


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd merged pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-688491543


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r576158296



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,10 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
 
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0.1.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0';

Review comment:
       @nvazquez do we (codewise) differentiate between 7.0 and 7.0.1.0? Pl check otherwise there is no need of adding support for 7.0.1.0 if it would fallback and use 7.0. Also can you check and add support for new guest OSs which are missing in the sql upgrade path.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-818029214


   @nvazquez can you kick smoketests against vmware 7.0 as well? And if we can get support for vsphere7 in Trillian?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778158348


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2691


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-795829259


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778042387


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2680


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r594869611



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -18,4 +18,85 @@
 --;
 -- Schema upgrade from 4.15.0.0 to 4.15.1.0
 --;
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+
+-- Add support for crxPod1Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (330, UUID(), 7, 'crxPod1Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 330, now(), 0);
+
+-- Add support for darwin19_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (331, UUID(), 7, 'macOS 10.15 (64 bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'darwin19_64Guest', 331, now(), 0);
+
+-- Add support for debian11_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (332, UUID(), 2, 'Debian GNU/Linux 11 (64-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11_64Guest', 332, now(), 0);
+
+-- Add support for debian11Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (333, UUID(), 2, 'Debian GNU/Linux 11 (32-bit)', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'debian11Guest', 333, now(), 0);
+
+-- Add support for vmkernel7Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (334, UUID(), 7, 'vmkernel7Guest', now());
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'vmkernel7Guest', 334, now(), 0);
+
+-- Add support for windows2019srv_64Guest from VMware 7.0
+INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0', 'windows2019srv_64Guest', 276, now(), 0);
+
+
+-- Add support for VMware 7.0.1.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0.1.0', 1024, 0, 59, 64, 1, 1);

Review comment:
       I've checked the code and this value comes from the SDK interaction to the hostMO.getHostAboutInfo().getApiVersion();
   
   In a test environment I get:
   ````
   MariaDB [cloud]> select id,name,status,version, hypervisor_version, hypervisor_type from host where type = 'Routing';
   +----+-------------+--------+-------------------+--------------------+-----------------+
   | id | name        | status | version           | hypervisor_version | hypervisor_type |
   +----+-------------+--------+-------------------+--------------------+-----------------+
   |  1 | 10.0.33.193 | Up     | 4.15.1.0-SNAPSHOT | 7.0.1.0            | VMware          |
   |  2 | 10.0.35.144 | Up     | 4.15.1.0-SNAPSHOT | 7.0.1.0            | VMware          |
   +----+-------------+--------+-------------------+--------------------+-----------------+
   2 rows in set (0.00 sec)
   
   ```` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-785837946


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2826


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-799968290


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-800176422


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r559987495



##########
File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
##########
@@ -170,6 +171,13 @@ public static ConsoleProxyAuthenticationResult authenticateConsoleAccess(Console
         authResult.setReauthentication(reauthentication);
         authResult.setHost(param.getClientHostAddress());
         authResult.setPort(param.getClientHostPort());
+        if (StringUtils.isNotBlank(param.getTicketAcquired())) {
+            s_logger.info("Host = " + param.getClientHostAddress() + ", hypervhost = " + param.getHypervHost() +
+                    " pass = " + param.getPassword() + " hostpass = " + param.getClientHostPassword() +
+                    " asd = " + param.getClientHostPort());
+            s_logger.info("Connecting using ticket " + param.getTicketAcquired() + " port 443");
+            authResult.setPort(443);

Review comment:
       @nvazquez is this port customizable at vCenter / host (or) fixed ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-728503454


   <b>Trillian test result (tid-3178)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36966 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3178-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 84 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 5.19 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.23 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.19 | test_templates.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r528060974



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -19,6 +19,10 @@
 -- Schema upgrade from 4.14.0.0 to 4.15.0.0
 --;
 
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+

Review comment:
       :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-777278421


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2674


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819935438


   <b>Trillian test result (tid-441)</b>
   Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36325 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t441-vmware-70u1.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.16 | test_diagnostics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 347.83 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 243.03 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r527469165



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -19,6 +19,10 @@
 -- Schema upgrade from 4.14.0.0 to 4.15.0.0
 --;
 
+-- Add support for VMware 7.0
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '7.0', 1024, 0, 59, 64, 1, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '7.0', guest_os_name, guest_os_id, utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='6.7';
+

Review comment:
       new guest os support in VMware 7.0 will be addressed here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-788030734


   @rhtyd @nvazquez this has `[WIP]` in the name. is it still a draft?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-817153933


   <b>Trillian test result (tid-399)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37625 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t399-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestVAppsVM>:setup | `Error` | 82.81 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-819491495


   @blueorangutan help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-816746778


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778020578


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-788550558


   @DaanHoogland it is ready for review, I have now removed the WIP tag on the name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-795864211


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 81


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-794140216


   @nvazquez can you rebase/force push?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-764398604


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-786505703


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4300: engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

rhtyd commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-820323593


   Merging based on tests and code reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778603809


   @DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

Posted by GitBox <gi...@apache.org>.

nvazquez commented on pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#issuecomment-778734194


   @davidjumani can you please review the CPVM/noVNC related commits?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org