Re: [PR] Update ACCEPT thread configurations [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on code in PR #10687:
URL: https://github.com/apache/trafficserver/pull/10687#discussion_r1379229376


##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -571,8 +571,10 @@ NetAccept::acceptLoopEvent(int event, Event *e)
 {
   (void)event;
   (void)e;
-  EThread *t = this_ethread();
-
+  EThread *t    = this_ethread();
+  NetHandler *h = get_NetHandler(t);

Review Comment:
   Interesting. Is this line a problem already then?
   https://github.com/apache/trafficserver/blob/fc3f12e5eb360a32845ddbf3cba64294c8cb1ddf/src/iocore/net/UnixNetAccept.cc#L58
   
   There's no verification at that point that the thread is a NET type. There is logic later in the function to verify NET threads, but only conditionally:
   https://github.com/apache/trafficserver/blob/fc3f12e5eb360a32845ddbf3cba64294c8cb1ddf/src/iocore/net/UnixNetAccept.cc#L114



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org