You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/04/28 12:17:24 UTC

[GitHub] [wicket] martin-g commented on a diff in pull request #513: WICKET-6977 More efficient hashcode computations

martin-g commented on code in PR #513:
URL: https://github.com/apache/wicket/pull/513#discussion_r860819542


##########
wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java:
##########
@@ -135,6 +135,11 @@ public boolean equals(Object o)
 	@Override
 	public int hashCode()
 	{
-		return Objects.hash(async, defer, charset);
+		// Not using `Objects.hash` for performance reasons
+		int result = super.hashCode();

Review Comment:
   I don't remember now but I guess those were generated by my IDE.
   I agree that super should be called!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org