You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Eamonn Dwyer (JIRA)" <ji...@apache.org> on 2009/06/05 17:40:07 UTC

[jira] Created: (CXF-2251) AssymetricBindingHandler swallows a PolicyException

AssymetricBindingHandler swallows a PolicyException
---------------------------------------------------

                 Key: CXF-2251
                 URL: https://issues.apache.org/jira/browse/CXF-2251
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
    Affects Versions: 2.2.2
            Reporter: Eamonn Dwyer


In the doSignBeforeEncrypt method there is 

catch (Exception e) {
   e.printStackTrace();
  //REVISIT
}

 I reckon something like this would be more appropriate.
catch (Exception e) {
            String reason = e.getMessage();
            LOG.log(Level.WARNING, "Sign before encryption failed due to : " + reason);
            throw new Fault(e);
}

I'll be submitting a patch for this soon


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-2251) AssymetricBindingHandler swallows a PolicyException

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2251.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.3
         Assignee: Daniel Kulp

Patch applied.  Thanks!

> AssymetricBindingHandler swallows a PolicyException
> ---------------------------------------------------
>
>                 Key: CXF-2251
>                 URL: https://issues.apache.org/jira/browse/CXF-2251
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.2.2
>            Reporter: Eamonn Dwyer
>            Assignee: Daniel Kulp
>             Fix For: 2.2.3
>
>
> In the doSignBeforeEncrypt method there is 
> catch (Exception e) {
>    e.printStackTrace();
>   //REVISIT
> }
>  I reckon something like this would be more appropriate.
> catch (Exception e) {
>             String reason = e.getMessage();
>             LOG.log(Level.WARNING, "Sign before encryption failed due to : " + reason);
>             throw new Fault(e);
> }
> I'll be submitting a patch for this soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2251) AssymetricBindingHandler swallows a PolicyException

Posted by "Eamonn Dwyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716651#action_12716651 ] 

Eamonn Dwyer commented on CXF-2251:
-----------------------------------

A fix for this in included in the patch for https://issues.apache.org/jira/browse/CXF-2194


> AssymetricBindingHandler swallows a PolicyException
> ---------------------------------------------------
>
>                 Key: CXF-2251
>                 URL: https://issues.apache.org/jira/browse/CXF-2251
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.2.2
>            Reporter: Eamonn Dwyer
>
> In the doSignBeforeEncrypt method there is 
> catch (Exception e) {
>    e.printStackTrace();
>   //REVISIT
> }
>  I reckon something like this would be more appropriate.
> catch (Exception e) {
>             String reason = e.getMessage();
>             LOG.log(Level.WARNING, "Sign before encryption failed due to : " + reason);
>             throw new Fault(e);
> }
> I'll be submitting a patch for this soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.