You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2018/12/10 07:02:31 UTC
[groovy-website] branch asf-site updated (69b899f -> e281c1a)
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git.
from 69b899f minor word change - test CI changes
new 85bc6e7 Update css to fix ribbon scrollbar overlap
new 817e781 Fix iframe height issue on api.html page
new 42433b1 Reduce iframe width to increase usability
new b6471f9 Restore full iframe width when ribbon hidden
new 0b20583 Fix side menu issue and update ribbon image
new e281c1a Make transition animation times consistent
The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
site/src/site/assets/css/style.css | 34 +++++++++------------
.../site/assets/img/horizontal-github-ribbon.png | Bin 0 -> 10431 bytes
site/src/site/layouts/page.groovy | 6 ++--
3 files changed, 18 insertions(+), 22 deletions(-)
create mode 100644 site/src/site/assets/img/horizontal-github-ribbon.png
[groovy-website] 06/06: Make transition animation times consistent
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit e281c1a5580cd09bcd28563c604e6217a14bf12d
Author: Paddy <p....@gmail.com>
AuthorDate: Sun Dec 9 17:20:25 2018 -0700
Make transition animation times consistent
---
site/src/site/assets/css/style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index 20f8b66..d756b97 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -812,8 +812,8 @@ html.noScroll body, html.noScroll .st-container, html.noScroll .st-pusher, html.
.st-container {
position: relative;
overflow: hidden;
- -webkit-transition: margin .25s, -webkit-transform .25s;
- transition: margin .25s, transform .25s
+ -webkit-transition: margin .5s, -webkit-transform .5s;
+ transition: margin .5s, transform .5s
}
.st-container.st-menu-open {
[groovy-website] 02/06: Fix iframe height issue on api.html page
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit 817e781b60d2681028763b7421fbcb7853bab456
Author: Paddy <p....@gmail.com>
AuthorDate: Sun Dec 9 12:46:52 2018 -0700
Fix iframe height issue on api.html page
After removing height styles on parent elements, the iframe element on
the api.html page was not showing full height.
To fix this, the height: 100% rule was replaced with height: 100vh.
---
site/src/site/assets/css/style.css | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index 5622d75..c1fb3c2 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -216,7 +216,7 @@ article .content time {
.doc-embed {
border: 0;
- width: 100%;
+ height: 100vh;
min-height: 100%;
}
[groovy-website] 05/06: Fix side menu issue and update ribbon image
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit 0b20583aeb29954b22f4f1ffc920c401f4c8945d
Author: Paddy <p....@gmail.com>
AuthorDate: Sun Dec 9 16:37:27 2018 -0700
Fix side menu issue and update ribbon image
Due to the removal of height: 100% from #st-container, the behaviour
when clicking the side menu became unpredictable.
To fix, the perspective transform was replaced by a simple margin
transform. It does not have the exact same effect as the perspective,
but it is pretty close and allows for the other issues to be fixed.
Additionally, the standard github ribbon aws image was replaced by a
horizontal one that was rotated 45deg to reduce the area that links to
github.
---
site/src/site/assets/css/style.css | 18 ++++++++----------
site/src/site/assets/img/horizontal-github-ribbon.png | Bin 0 -> 10431 bytes
site/src/site/layouts/page.groovy | 4 ++--
3 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index af5936f..20f8b66 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -220,7 +220,7 @@ article .content time {
.doc-embed {
border: 0;
border-right: 1px solid #e7e7e7;
- width: 87%;
+ width: 88%;
height: 100vh;
min-height: 100%;
}
@@ -337,7 +337,6 @@ body, html {
font-family: "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
padding: 0;
margin: 0;
- background: #FFF;
color: #343437;
line-height: 25px;
font-weight: normal;
@@ -812,7 +811,13 @@ html.noScroll body, html.noScroll .st-container, html.noScroll .st-pusher, html.
.st-container {
position: relative;
- overflow: hidden
+ overflow: hidden;
+ -webkit-transition: margin .25s, -webkit-transform .25s;
+ transition: margin .25s, transform .25s
+}
+
+.st-container.st-menu-open {
+ margin: 10px -15px -10px 15px;
}
.st-pusher {
@@ -820,8 +825,6 @@ html.noScroll body, html.noScroll .st-container, html.noScroll .st-pusher, html.
left: 0;
z-index: 99;
height: 100%;
- -webkit-transition: -webkit-transform .5s;
- transition: transform .5s
}
.st-pusher::after {
@@ -937,11 +940,6 @@ html.noScroll body, html.noScroll .st-container, html.noScroll .st-pusher, html.
color: #fff
}
-.st-effect-9.st-container {
- -webkit-perspective: 10000px;
- perspective: 10000px
-}
-
.st-effect-9 .st-pusher {
-webkit-transform-style: preserve-3d;
transform-style: preserve-3d
diff --git a/site/src/site/assets/img/horizontal-github-ribbon.png b/site/src/site/assets/img/horizontal-github-ribbon.png
new file mode 100644
index 0000000..a3ab20d
Binary files /dev/null and b/site/src/site/assets/img/horizontal-github-ribbon.png differ
diff --git a/site/src/site/layouts/page.groovy b/site/src/site/layouts/page.groovy
index 27f1ba9..407231f 100644
--- a/site/src/site/layouts/page.groovy
+++ b/site/src/site/layouts/page.groovy
@@ -32,8 +32,8 @@ body {
div(id: 'fork-me') {
a(href: 'https://github.com/apache/groovy') {
img(
- style: "position: fixed; top: 0px; right: 0px; border: 0; z-index: 100",
- src: 'https://camo.githubusercontent.com/365986a132ccd6a44c23a9169022c0b5c890c387/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f7265645f6161303030302e706e67', alt: 'Fork me on GitHub', 'data-canonical-src': 'https://s3.amazonaws.com/github/ribbons/forkme_right_red_aa0000.png'
+ style: "position: fixed; top: 20px; right: -58px; border: 0; z-index: 100; transform: rotate(45deg);",
+ src: '/img/horizontal-github-ribbon.png'
)
}
}
[groovy-website] 01/06: Update css to fix ribbon scrollbar overlap
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit 85bc6e77c053fd8763db077e068cd020858c96fc
Author: Paddy <p....@gmail.com>
AuthorDate: Sat Dec 8 22:41:31 2018 -0700
Update css to fix ribbon scrollbar overlap
Previously the 'Fork me on GitHub' image overlapped the scrollbar.
This was most notable on Windows, but also existed to some extent on Mac
OS and Linux distros.
Problem: The visible scrollbar did not belong to the body element, and
so the full width of the window was not taken into account by the
position:fixed style of the ribbon.
Solution: The solution was to ensure that only the scrollbar from the
body element is used and visible.
Visually checked on Chrome/Firefox/Safar on Mac OS, Chrome/IE11 on
Windows and Firefox on Debian.
---
site/src/site/assets/css/style.css | 11 ++---------
site/src/site/layouts/page.groovy | 4 ++--
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index dd3f93e..5622d75 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -778,7 +778,8 @@ ul.nav-sidebar li.active a {
}
body {
- background: #444
+ background: #444;
+ overflow: auto;
}
html.noScroll {
@@ -789,20 +790,12 @@ html.noScroll body, html.noScroll .st-container, html.noScroll .st-pusher, html.
overflow: hidden
}
-html, body, .st-container, .st-pusher, .st-content {
- overflow: auto
-}
-
.sign-in-fa-icon:before {
font-family: FontAwesome;
content: '\f090';
padding-right: 10px;
}
-#st-container {
- height: 100%;
-}
-
.st-content {
background: white
}
diff --git a/site/src/site/layouts/page.groovy b/site/src/site/layouts/page.groovy
index bff19e9..27f1ba9 100644
--- a/site/src/site/layouts/page.groovy
+++ b/site/src/site/layouts/page.groovy
@@ -32,7 +32,7 @@ body {
div(id: 'fork-me') {
a(href: 'https://github.com/apache/groovy') {
img(
- style: "position: fixed; top: -14px; right: -14px; border: 0; z-index: 100",
+ style: "position: fixed; top: 0px; right: 0px; border: 0; z-index: 100",
src: 'https://camo.githubusercontent.com/365986a132ccd6a44c23a9169022c0b5c890c387/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f7265645f6161303030302e706e67', alt: 'Fork me on GitHub', 'data-canonical-src': 'https://s3.amazonaws.com/github/ribbons/forkme_right_red_aa0000.png'
)
}
@@ -87,4 +87,4 @@ body {
'''
}
-yieldUnescaped '</html>'
\ No newline at end of file
+yieldUnescaped '</html>'
[groovy-website] 03/06: Reduce iframe width to increase usability
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit 42433b11dab456dd32662019761b018c94112c8b
Author: Paddy <p....@gmail.com>
AuthorDate: Sun Dec 9 12:48:01 2018 -0700
Reduce iframe width to increase usability
Issue: The ribbon still overlaps the iframe scrollbar on the api.html
page.
This is relatively unavoidable due to the nature of loading a page
within a page.
Solution: The best solution seems to be to reduce the width of the
iframe.
Pros:
- Scrollbar is fully accessible
- It is clear that the documentation is being loaded in an iframe
- The distinction between body and iframe scrollbars is clear
Cons:
- The width of the documentation is reduced
---
site/src/site/assets/css/style.css | 2 ++
1 file changed, 2 insertions(+)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index c1fb3c2..aa1cf49 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -216,6 +216,8 @@ article .content time {
.doc-embed {
border: 0;
+ border-right: 1px solid #e7e7e7;
+ width: 87%;
height: 100vh;
min-height: 100%;
}
[groovy-website] 04/06: Restore full iframe width when ribbon hidden
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/groovy-website.git
commit b6471f9b1e82eb16e0128878f3ea48dc517042ba
Author: Paddy <p....@gmail.com>
AuthorDate: Sun Dec 9 13:01:09 2018 -0700
Restore full iframe width when ribbon hidden
---
site/src/site/assets/css/style.css | 3 +++
1 file changed, 3 insertions(+)
diff --git a/site/src/site/assets/css/style.css b/site/src/site/assets/css/style.css
index aa1cf49..af5936f 100644
--- a/site/src/site/assets/css/style.css
+++ b/site/src/site/assets/css/style.css
@@ -79,6 +79,9 @@ a.navbar-brand {
/* specific to index.html */
@media (max-width: 999px) {
+ .doc-embed {
+ width: 100% !important;
+ }
#fork-me {
display: none;
}