You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2025/06/18 04:51:09 UTC
(camel) branch main updated: CAMEL-22152 - Fix test mllpTcp (#18382)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 2d9a689705a CAMEL-22152 - Fix test mllpTcp (#18382)
2d9a689705a is described below
commit 2d9a689705a9834babeeeb441a105d1eabc3b8ed
Author: Aurélien Pupier <ap...@redhat.com>
AuthorDate: Wed Jun 18 06:51:03 2025 +0200
CAMEL-22152 - Fix test mllpTcp (#18382)
the test was flaky, very often. In fact, the test was checking the bad
things. it was passing by error just because 22 messages are sent and
the second one was taking too much time.
Technically, the test should expect two completed message because
org.apache.camel.component.mllp.MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.requireEndOfData()
method is returning false. So in
org.apache.camel.component.mllp.TcpServerConsumerEndOfDataAndValidationTestSupport.runMessageWithoutEndOfDataByte(),
even the second message sent without end of data is valid.
Signed-off-by: Aurélien Pupier <ap...@redhat.com>
---
.../mllp/MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.java
index 7cb3e2e96e7..3577200350f 100644
--- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.java
+++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithValidationTest.java
@@ -104,7 +104,7 @@ public class MllpTcpServerConsumerOptionalEndOfDataWithValidationTest
@Override
@Test
public void testMessageWithoutEndOfDataByte() {
- expectedCompleteCount = 1;
+ expectedCompleteCount = 2;
assertDoesNotThrow(this::runMessageWithoutEndOfDataByte);
}