You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by schonfeld <gi...@git.apache.org> on 2015/10/06 20:35:16 UTC
[GitHub] storm pull request: [STORM-1090] Nimbus HA should support `storm.l...
GitHub user schonfeld opened a pull request:
https://github.com/apache/storm/pull/783
[STORM-1090] Nimbus HA should support `storm.local.hostname`
Nimbus HA's `NimbusInfo` class relies on each nimbus's hostname for network reachability. This is a show-stopper in situations that utilize Config.STORM_LOCAL_HOSTNAME / `storm.local.hostname`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schonfeld/storm nimbus-ha-support-storm-local-hostname
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit ed7b4869d3cfd53279d34bf300abdf6fb50958b6
Author: Michael Schonfeld <mi...@schonfeld.org>
Date: 2015-10-06T16:31:03Z
nimbus host should support Config.STORM_LOCAL_HOSTNAME
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1090] Nimbus HA should support `storm.l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/783
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1090] Nimbus HA should support `storm.l...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/783#issuecomment-145997525
+1
Config.STORM_LOCAL_HOSTNAME is already used for supervisors/workers to report its hostname to nimbus, so it makes sense for nimbuses to report its hostname by STORM_LOCAL_HOSTNAME to each other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1090] Nimbus HA should support `storm.l...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/783#issuecomment-146677802
+1 Nice catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---