You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org> on 2010/11/02 13:18:04 UTC

[jira] Commented: (SUREFIRE-656) JUnit 4.8 @Category support

    [ http://jira.codehaus.org/browse/SUREFIRE-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241795#action_241795 ] 

Kristian Rosenvold commented on SUREFIRE-656:
---------------------------------------------

I'm sure the best way to handle this would be to do it inside the junit47 testrunner. I initially named this runner "junitcore" testrunner, and I think the name should be changed back from junit47->junitcore, since this provider is really about invoking tests through the junitcore api. You'll be looking at JUnitCoreTestSet and friends.

Make sure your test coverage is good and I'm certain this patch will be picked up quickly. You do not specifically need to rename the "47" provider in the patch; it's better if I do that when I review it.

> JUnit 4.8 @Category support
> ---------------------------
>
>                 Key: SUREFIRE-656
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-656
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Junit 4.x support
>    Affects Versions: 2.7
>         Environment: any
>            Reporter: KP
>
> I am interested in adding JUnit's {{@Category}} support.  TestNG already has group support in Surefire, so this would be a nice addition.
> I'm wondering if someone could point me in the right direction.  Unfortunately, I'm not familiar with the Surefire source code.
> 1. Do I need to add another provider or something?
> 1. Should I just subclass {{SurefireTestSuite}} in the same manner as {{JUnitCoreDirectoryTestSuite}}?
> 1. Should I model 
> Any help would be greatly appreciated.  I have some free time and I'd love to submit a patch this week.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira