You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by mc...@apache.org on 2013/09/24 20:22:26 UTC
svn commit: r1525959 - in /qpid/proton/trunk/proton-c/bindings/ruby:
ChangeLog lib/qpid_proton/messenger.rb
Author: mcpierce
Date: Tue Sep 24 18:22:26 2013
New Revision: 1525959
URL: http://svn.apache.org/r1525959
Log:
PROTON-427: Removed the flag argument from Messenger.settle
Made the API more consistent with the accept and reject methods.
Modified:
qpid/proton/trunk/proton-c/bindings/ruby/ChangeLog
qpid/proton/trunk/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
Modified: qpid/proton/trunk/proton-c/bindings/ruby/ChangeLog
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/ruby/ChangeLog?rev=1525959&r1=1525958&r2=1525959&view=diff
==============================================================================
--- qpid/proton/trunk/proton-c/bindings/ruby/ChangeLog (original)
+++ qpid/proton/trunk/proton-c/bindings/ruby/ChangeLog Tue Sep 24 18:22:26 2013
@@ -1,3 +1,6 @@
+Version 0.6:
+ * PROTON-427: Removed the flag argument from Messenger.settle.
+
version 0.5:
* Duck typed the Array class to work with Qpid::Proton::Data.
* Duck typed the Hash class to work with Qpid::Proton::Data.
Modified: qpid/proton/trunk/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb?rev=1525959&r1=1525958&r2=1525959&view=diff
==============================================================================
--- qpid/proton/trunk/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb (original)
+++ qpid/proton/trunk/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb Tue Sep 24 18:22:26 2013
@@ -338,13 +338,17 @@ module Qpid
# ==== Options
#
# * tracker - the tracker
- # * flag - the flag
#
# ==== Examples
#
- def settle(tracker, flag)
+ def settle(tracker)
raise TypeError.new("invalid tracker: #{tracker}") unless valid_tracker?(tracker)
- raise TypeError.new("invalid flag: #{flag}") unless Qpid::Proton::Tracker.valid_flag?(flag)
+ if tracker.nil? then
+ tracker = self.incoming_tracker
+ flag = Cproton::PN_CUMULATIVE
+ else
+ flag = 0
+ end
Cproton.pn_messenger_settle(@impl, tracker.impl, flag)
end
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org