[jira] [Comment Edited] (FLINK-15438) Counter metrics are incorrectly reported as total counts to DataDog

["Jörn Kottmann (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028127#comment-17028127 ] 

Jörn Kottmann edited comment on FLINK-15438 at 2/1/20 3:58 PM:
---------------------------------------------------------------

No, didn't mange to find the exact cause.

The current implementation is sending counts that are really wrong, with my changes this is much better. 

Should I send the PR for it and you could give it a critical review? 




was (Author: joern):
No, didn't mange to find the exact cause.

The current implementation is sending counts that are really wrong, with my changes this is much better. 

Should I send the PR for it you could give it a critical review? 



> Counter metrics are incorrectly reported as total counts to DataDog
> -------------------------------------------------------------------
>
>                 Key: FLINK-15438
>                 URL: https://issues.apache.org/jira/browse/FLINK-15438
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Metrics
>    Affects Versions: 1.9.1
>            Reporter: Jörn Kottmann
>            Assignee: Jörn Kottmann
>            Priority: Minor
>
> The Flink semantics of a counter are not matching with the counters in DataDog.
> In Flink a counter counts the total of increment and decrement calls.
> In DataDog a counter is a rate over the reporting interval. 
> The Flink implementation of the DataDog reporter seems to send the Flink counter value each time the metrics are reported. Correct would be to send the delta of the counter since the last report.
> There are some features in DataDog which are easier to use if this could be fixed, e.g. alerts based on counters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)