You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/22 11:38:02 UTC

[GitHub] [shardingsphere] zoujianchao commented on a change in pull request #10893: fixed #10863 Update tableNameOrAlias to equalsIgnoreCase

zoujianchao commented on a change in pull request #10893:
URL: https://github.com/apache/shardingsphere/pull/10893#discussion_r656134207



##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionsContextEngineTest.java
##########
@@ -391,4 +391,49 @@ private void assertCreateProjectionsContextWithTemporaryTable(final SelectStatem
                 .createProjectionsContext(selectStatementContext.getFromSimpleTableSegments(), projectionsSegment, groupByContext, new OrderByContext(Collections.emptyList(), false));
         assertNotNull(actual);
     }
+
+    @Test
+    public void assertCreateProjectionsContextWhenTableNameOrAliasIgnoreCaseForMySQL() {
+        assertCreateProjectionsContextWhenTableNameOrAliasIgnoreCase(new MySQLSelectStatement(), new MySQLSelectStatement());
+    }
+

Review comment:
       my idea, it's not flexible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org