You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/04/22 08:17:57 UTC
[GitHub] [incubator-sedona] Arindam-Jain opened a new pull request, #619: Added ST_IsEmpty
Arindam-Jain opened a new pull request, #619:
URL: https://github.com/apache/incubator-sedona/pull/619
## Is this PR related to a proposed Issue?
SEDONA-98
## What changes were proposed in this PR?
Added ST_IsEmpty function to SQL and flink
## How was this patch tested?
Added unit tests
## Did this PR include necessary documentation updates?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107373764
> > Do NOT commit .DS_Store file
>
> @jiayuasu Can I add it to .gitignore ?
Just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107372946
> Do NOT commit .DS_Store file
@jiayuasu Can I add it to .gitignore ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107388031
.DS_Store file removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu merged pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107378279
> > > Do NOT commit .DS_Store file
> >
> >
> > @jiayuasu Can I add it to .gitignore ?
>
> Just remove it.
Okay!
> > > Do NOT commit .DS_Store file
> >
> >
> > @jiayuasu Can I add it to .gitignore ?
>
> Just remove it.
Yes working on it, was waiting for checks to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107371619
Y
> Do NOT commit .DS_Store file
Yes will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107391815
> Please add the JIRA url of the ticket in the description. Just like what other PRs do.
Sure, will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1107391463
Please add the JIRA url of the ticket in the description. Just like what other PRs do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] Arindam-Jain commented on pull request #619: [SEDONA-98] Added ST_IsEmpty function
Posted by GitBox <gi...@apache.org>.
Arindam-Jain commented on PR #619:
URL: https://github.com/apache/incubator-sedona/pull/619#issuecomment-1106799559
@jiayuasu I have changed GeomUtils to geometry.isEmpty() function. Could you please let me know what else is inconsistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org