[jira] [Comment Edited] (IGNITE-13847) Make GridEncryptionManager#onWalSegmentRemoved async

["Kirill Tkalenko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-13847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249661#comment-17249661 ] 

Kirill Tkalenko edited comment on IGNITE-13847 at 12/15/20, 12:30 PM:
----------------------------------------------------------------------

Hi [~akalashnikov], [~sk0x50] suggested you to review it too. Can you make code review?


was (Author: ktkalenko@gridgain.com):
Hi [~akalashnikov], [~sk0x50] suggested you to review it too. Can you can code review?

> Make GridEncryptionManager#onWalSegmentRemoved async
> ----------------------------------------------------
>
>                 Key: IGNITE-13847
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13847
>             Project: Ignite
>          Issue Type: Improvement
>          Components: persistence
>            Reporter: Kirill Tkalenko
>            Assignee: Kirill Tkalenko
>            Priority: Major
>              Labels: IEP-18
>             Fix For: 2.10
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When implementing IGNITE-13831 I was faced with deadlock.
> When execute *FileWriteAheadLogManager#rollOver*, begin to clean WAL archive since we have reached the *DataStorageConfiguration#maxWalArchiveSize*, after deleting a segment, execute the *GridEncryptionManager#onWalSegmentRemoved* that wants to write to the metastore, but it will not succeed, since it will wait for *FileWriteAheadLogManager#rollOver*.
> I suggest making the *GridEncryptionManager#onWalSegmentRemoved* asynchronous in a separate pool, for example, as a *CacheGroupPageScanner#singleExecSvc*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)