You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/06 22:14:00 UTC
[jira] [Work logged] (GOBBLIN-1278) Close HiveRegister in
completion action usage
[ https://issues.apache.org/jira/browse/GOBBLIN-1278?focusedWorklogId=496219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496219 ]
ASF GitHub Bot logged work on GOBBLIN-1278:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 22:13
Start Date: 06/Oct/20 22:13
Worklog Time Spent: 10m
Work Description: zxcware opened a new pull request #3118:
URL: https://github.com/apache/incubator-gobblin/pull/3118
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-1278
### Description
- [x] Here are some details about my PR:
- In a compaction with watermark flow, `CompactionHiveRegistrationAction` and `CompactionWatermarkAction` can concurrently alter a table, which may end up old table parameters replace new ones. To serialize, the idea is to `close` the `HiveRegister` instance, waiting for all hive updates complete, before returning.
### Tests
- [] My PR adds the following tests:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 496219)
Remaining Estimate: 0h
Time Spent: 10m
> Close HiveRegister in completion action usage
> ---------------------------------------------
>
> Key: GOBBLIN-1278
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1278
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In a compaction with watermark flow, `CompactionHiveRegistrationAction` and `CompactionWatermarkAction` can concurrently alter a table, which may end up old table parameters replace new ones. To serialize, the idea is to `close` the `HiveRegister` instance, waiting for all hive updates complete, before returning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)