You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/06/19 09:23:02 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #8283: [INLONG-8282][Manager] Ensure that the field length in the request is consistent with the length limit in mysql
fuweng11 opened a new pull request, #8283:
URL: https://github.com/apache/inlong/pull/8283
### Prepare a Pull Request
- Fixes #8282
### Motivation
Ensure that the field length in the request is consistent with the length limit in mysql.
### Modifications
Ensure that the field length in the request is consistent with the length limit in mysql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #8283: [INLONG-8282][Manager] Ensure that the field length in the request is consistent with the length limit in DB
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #8283:
URL: https://github.com/apache/inlong/pull/8283#discussion_r1234687231
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupRequest.java:
##########
@@ -49,8 +49,8 @@ public abstract class InlongGroupRequest extends BaseInlongGroup {
@ApiModelProperty(value = "Inlong group id", required = true)
@NotBlank(message = "inlongGroupId cannot be blank")
- @Length(min = 4, max = 100, message = "length must be between 4 and 100")
- @Pattern(regexp = "^[a-z0-9_.-]{4,100}$", message = "only supports lowercase letters, numbers, '-', or '_'")
+ @Length(min = 4, max = 256, message = "length must be between 4 and 256")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #8283: [INLONG-8282][Manager] Increase the length of the partial ID or name field
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8283:
URL: https://github.com/apache/inlong/pull/8283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8283: [INLONG-8282][Manager] Ensure that the field length in the request is consistent with the length limit in DB
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8283:
URL: https://github.com/apache/inlong/pull/8283#discussion_r1234215984
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupRequest.java:
##########
@@ -49,8 +49,8 @@ public abstract class InlongGroupRequest extends BaseInlongGroup {
@ApiModelProperty(value = "Inlong group id", required = true)
@NotBlank(message = "inlongGroupId cannot be blank")
- @Length(min = 4, max = 100, message = "length must be between 4 and 100")
- @Pattern(regexp = "^[a-z0-9_.-]{4,100}$", message = "only supports lowercase letters, numbers, '-', or '_'")
+ @Length(min = 4, max = 256, message = "length must be between 4 and 256")
Review Comment:
The design suggestion is to reserve a portion of the buffer for defining the field length in DB, and not fully utilize it to prevent unpredictable errors such as character transcoding.
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupRequest.java:
##########
@@ -49,8 +49,8 @@ public abstract class InlongGroupRequest extends BaseInlongGroup {
@ApiModelProperty(value = "Inlong group id", required = true)
@NotBlank(message = "inlongGroupId cannot be blank")
- @Length(min = 4, max = 100, message = "length must be between 4 and 100")
- @Pattern(regexp = "^[a-z0-9_.-]{4,100}$", message = "only supports lowercase letters, numbers, '-', or '_'")
+ @Length(min = 4, max = 256, message = "length must be between 4 and 256")
Review Comment:
In this case, the field length in the DB can be defined as 256, but the field length in user interaction is limited to 200, which is also a reasonable approach in terms of user understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8283: [INLONG-8282][Manager] Ensure that the field length in the request is consistent with the length limit in DB
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8283:
URL: https://github.com/apache/inlong/pull/8283#discussion_r1234777170
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupRequest.java:
##########
@@ -49,8 +49,8 @@ public abstract class InlongGroupRequest extends BaseInlongGroup {
@ApiModelProperty(value = "Inlong group id", required = true)
@NotBlank(message = "inlongGroupId cannot be blank")
- @Length(min = 4, max = 100, message = "length must be between 4 and 100")
- @Pattern(regexp = "^[a-z0-9_.-]{4,100}$", message = "only supports lowercase letters, numbers, '-', or '_'")
+ @Length(min = 4, max = 200, message = "length must be between 4 and 200")
+ @Pattern(regexp = "^[a-zA-Z0-9_.-]{4,200}$", message = "only supports letters, numbers, '-', or '_'")
Review Comment:
And supports '.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org