[GitHub] [skywalking-showcase] kezhenxu94 commented on a change in pull request #14: add java agent injector

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-showcase/pull/14#discussion_r775097165



##########
File path: deploy/platform/kubernetes/features.mk
##########
@@ -81,3 +81,27 @@ undeploy.feature-kubernetes-monitor:
 	@kubectl delete --ignore-not-found -f https://raw.githubusercontent.com/kubernetes/kube-state-metrics/v2.2.4/examples/standard/cluster-role-binding.yaml
 	@kubectl delete --ignore-not-found -f https://raw.githubusercontent.com/kubernetes/kube-state-metrics/v2.2.4/examples/standard/service.yaml
 	@kubectl delete --ignore-not-found -f https://raw.githubusercontent.com/kubernetes/kube-state-metrics/v2.2.4/examples/standard/deployment.yaml
+
+# @feature: java agent injector

Review comment:
       Can you use this comment pattern: `# @feature: <feature-name>; <what and why we need this step in this feature>`. The same for other comments added in this PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org