[GitHub] [wicket] martin-g commented on a diff in pull request #591: Dependencies are excluded from final jar

["martin-g (via GitHub)" <gi...@apache.org>]

martin-g commented on code in PR #591:
URL: https://github.com/apache/wicket/pull/591#discussion_r1221661407


##########
wicket-commons-fileupload/pom.xml:
##########
@@ -317,13 +317,9 @@
       <plugin>
         <groupId>org.apache.felix</groupId>
         <artifactId>maven-bundle-plugin</artifactId>
-        <dependencies>
-          <dependency>
-            <groupId>biz.aQute.bnd</groupId>
-            <artifactId>biz.aQute.bndlib</artifactId>
-            <version>6.4.0</version>
-          </dependency>
-        </dependencies>
+        <configuration>
+          <excludeDependencies>true</excludeDependencies>

Review Comment:
   We will merge this PR as is.
   If anyone has ideas for improvements please open a new one!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org