Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]

["kou (via GitHub)" <gi...@apache.org>]

kou commented on issue #40766:
URL: https://github.com/apache/arrow/issues/40766#issuecomment-2017029963

   Does this work?
   
   ```diff
   diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
   index 3d1b621db0..90c45b2d40 100644
   --- a/cpp/src/arrow/CMakeLists.txt
   +++ b/cpp/src/arrow/CMakeLists.txt
   @@ -1185,7 +1185,9 @@ add_subdirectory(testing)
    
    add_subdirectory(array)
    add_subdirectory(c)
   -add_subdirectory(compute)
   +if(ARROW_COMPUTE)
   +  add_subdirectory(compute)
   +endif()
    add_subdirectory(io)
    add_subdirectory(tensor)
    add_subdirectory(util)
   diff --git a/cpp/src/arrow/compute/CMakeLists.txt b/cpp/src/arrow/compute/CMakeLists.txt
   index badcf4f2f2..11d6479451 100644
   --- a/cpp/src/arrow/compute/CMakeLists.txt
   +++ b/cpp/src/arrow/compute/CMakeLists.txt
   @@ -19,10 +19,8 @@ add_custom_target(arrow-compute-tests)
    
    arrow_install_all_headers("arrow/compute")
    
   -if(ARROW_COMPUTE)
   -  # pkg-config support
   -  arrow_add_pkg_config("arrow-compute")
   -endif()
   +# pkg-config support
   +arrow_add_pkg_config("arrow-compute")
    
    #
    # Unit tests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org