You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2025/05/24 07:59:46 UTC
[PR] rename deadline column to "time" in Deadline Table [airflow]
rawwar opened a new pull request, #51026:
URL: https://github.com/apache/airflow/pull/51026
renaming the column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar merged PR #51026:
URL: https://github.com/apache/airflow/pull/51026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #51026:
URL: https://github.com/apache/airflow/pull/51026#discussion_r2142076016
##########
airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Change the Deadline column in the Deadline table from DateTime to UTC DateTime.
Review Comment:
Yeah, that's correct. (It will mean anyone trying to have a persistent DB following main will need to db reset or manually fix things, but that is to be expected if you follow main)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #51026:
URL: https://github.com/apache/airflow/pull/51026#discussion_r2141810549
##########
airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Change the Deadline column in the Deadline table from DateTime to UTC DateTime.
Review Comment:
I think, that's true for any released version. But, since, this is for 3.1.0, we can do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #51026:
URL: https://github.com/apache/airflow/pull/51026#discussion_r2138600162
##########
airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Change the Deadline column in the Deadline table from DateTime to UTC DateTime.
Review Comment:
Wait, can we modify migrations? I could certainly be wrong, but I thought these were pretty immutable once they get merged and changing them would break stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org