You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/10/01 19:32:44 UTC
[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 )
Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges
......................................................................
Patch Set 3:
(1 comment)
I looked at the interface changes and the tests and this seems good. I haven't done a detailed review of the code but you should feel free to move forward without me doing that (I don't want to hold this up).
http://gerrit.cloudera.org:8080/#/c/11520/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11520/3//COMMIT_MSG@28
PS3, Line 28: * extended disk-io-mgr-test.cc with sub-ranges
I'd suggest running the standalone disk-io-mgr-stress-test with -duration_sec=0 for a while just to make sure that hasn't regressed.
--
To view, visit http://gerrit.cloudera.org:8080/11520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea26ba386713990f7671aab5a372cf449b8d51e4
Gerrit-Change-Number: 11520
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 19:32:44 +0000
Gerrit-HasComments: Yes