You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/04 04:16:44 UTC

[GitHub] [superset] etr2460 commented on a diff in pull request #19887: fix(hive): Workaround for Python 3.9 s3 transfer issue

etr2460 commented on code in PR #19887:
URL: https://github.com/apache/superset/pull/19887#discussion_r864445256


##########
superset/db_engine_specs/hive.py:
##########
@@ -80,6 +81,7 @@ def upload_to_s3(filename: str, upload_prefix: str, table: Table) -> str:
         filename,
         bucket_path,
         os.path.join(upload_prefix, table.table, os.path.basename(filename)),
+        Config=TransferConfig(use_threads=False),

Review Comment:
   ```suggestion
           # Disabling threading because it breaks python 3.9
           Config=TransferConfig(use_threads=False),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org