You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2024/08/20 20:45:39 UTC
[PR] feat: Revendor flatcc [arrow-nanoarrow]
bkietz opened a new pull request, #592:
URL: https://github.com/apache/arrow-nanoarrow/pull/592
After https://github.com/dvidelabs/flatcc/pull/289 flatcc will not enforce alignment on empty vectors. This will let us unskip the null_trivial case in the integration tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Revendor flatcc [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #592:
URL: https://github.com/apache/arrow-nanoarrow/pull/592#issuecomment-2303525924
> --all-files which overrides exclusions
This is not true for me locally (e.g., if I remove `thirdparty/` then all of flatcc becomes reformatted when I run `pre-commit run --all-files`), but other than this and ADBC I am not all that familiar with the details. We could also just reformat it as part of the vendoring if it causes too much trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Revendor flatcc [arrow-nanoarrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz merged PR #592:
URL: https://github.com/apache/arrow-nanoarrow/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Revendor flatcc [arrow-nanoarrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on PR #592:
URL: https://github.com/apache/arrow-nanoarrow/pull/592#issuecomment-2302911315
> to possibly add `flatcc_generated.h` to the files we ignore
It is already excluded, and everything in `thirdparty/` too. However the CI job uses `--all-files` which overrides exclusions. This seems to have been the case since `pre-commit` was added to the project, so I assume we want to remove that flag now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org