[GitHub] [tvm] vinx13 commented on a diff in pull request #13530: [TOPI] Use integer arithmetic for topi.image.resize

[GitBox <gi...@apache.org>]

vinx13 commented on code in PR #13530:
URL: https://github.com/apache/tvm/pull/13530#discussion_r1037553798


##########
python/tvm/topi/utils.py:
##########
@@ -539,3 +542,365 @@ def is_target(names):
 def is_dynamic_shape(shape):
     """Checks if any part of a shape is dynamic"""
     return any([isinstance(x, (Any, SizeVar)) for x in shape])
+
+
+class Fraction:
+    """Utility class for representing integer ratios
+
+    TVM's simplifier has specific handling for integer expressions,
+    especially as they appear in indexing.  As the simplifier is used
+    to check if an optimization is permissible (e.g. vectorized
+    computations require linear buffer access), use of integer
+    expressions may provide significant performance benefits.
+    However, writing the simplified form

Review Comment:
   this sentence is not complete



##########
src/tir/transforms/remove_no_op.cc:
##########
@@ -29,6 +29,7 @@
 #include <tvm/tir/stmt_functor.h>
 #include <tvm/tir/transform.h>
 
+#include <cstdlib>

Review Comment:
   not needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org