[GitHub] [druid] clintropolis commented on pull request #12918: Add druid-multi-stage-query extension.

[GitBox <gi...@apache.org>]

clintropolis commented on PR #12918:
URL: https://github.com/apache/druid/pull/12918#issuecomment-1225060847

   >I reviewed the LGTM alerts and they look OK to me. I don't think suppression is the way to go, since I wouldn't want to add a suppression at the end of the path. (The LGTM check is looking for user-provided data that makes its way into a file path; in these six cases, it's all task IDs, which are enforced as being path-safe.) So the best thing to do seems to be to merge the patch without suppressing the alerts.
   
   Yeah, I guess it doesn't like the validation method changing from void to returning a thing, and confused some stuff? It seems like these places should all be safe though, so I think can ignore them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org