[GitHub] [superset] villebro commented on a change in pull request #13224: build(docker): publish latest-release tag

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #13224:
URL: https://github.com/apache/superset/pull/13224#discussion_r579004947



##########
File path: .github/workflows/docker_build_push.sh
##########
@@ -26,7 +26,7 @@ if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
   LATEST_TAG="pr-${PR_NUM}"
 elif [[ "${GITHUB_EVENT_NAME}" == "release" ]]; then
   REFSPEC=$(echo "${GITHUB_REF}" | sed 's:refs/tags/::' | head -c 40)
-  LATEST_TAG="${REFSPEC}"
+  LATEST_TAG="latest-release"

Review comment:
       I think we should aim to align the GitHub and Docker Hub tags. It will be slightly confusing if GitHub `latest` is `latest-release` or `stable` on Docker Hub, and `master` on GitHub is `latest` on Docker Hub.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org