You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/26 16:13:44 UTC
[GitHub] [pulsar] Zhen-hao opened a new pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Zhen-hao opened a new pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801
add documentation for https://github.com/apache/pulsar/pull/11238
@Anonymitaet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801#discussion_r697064611
##########
File path: site2/docs/schema-understand.md
##########
@@ -474,6 +474,24 @@ Message<GenericRecord> msg = consumer.receive() ;
GenericRecord record = msg.getValue();
```
+### Native Avro Schema
+
+When migrating or ingesting event/message data from external systems such as Kafka and Cassandra, the events are often already serialized in Avro format. The schemas have been validated and stored by those systems or a dedicated service such as a schema registry. In such cases, a Pulsar producer doesn't need to repeat the schema validation step when sending the ingested events to a topic.
+Hence, we provide `Schema.NATIVE_AVRO` to turn an `org.apache.avro.Schema` object into a schema instance of Pulsar that accepts a serialized Avro payload without validating it against the schema specified.
Review comment:
This sentence is too long, which affects the readability and makes it hard to understand. Can you revise it?
##########
File path: site2/docs/schema-understand.md
##########
@@ -474,6 +474,24 @@ Message<GenericRecord> msg = consumer.receive() ;
GenericRecord record = msg.getValue();
```
+### Native Avro Schema
+
+When migrating or ingesting event/message data from external systems such as Kafka and Cassandra, the events are often already serialized in Avro format. The schemas have been validated and stored by those systems or a dedicated service such as a schema registry. In such cases, a Pulsar producer doesn't need to repeat the schema validation step when sending the ingested events to a topic.
Review comment:
```suggestion
When migrating or ingesting event or message data from external systems (such as Kafka and Cassandra), the events are often already serialized in Avro format. The schemas have been validated and stored by external systems or a dedicated service (such as a schema registry). In such cases, a Pulsar producer doesn't need to repeat the schema validation step when sending the ingested events to a topic.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801#issuecomment-906847761
Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Zhen-hao commented on pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Posted by GitBox <gi...@apache.org>.
Zhen-hao commented on pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801#issuecomment-906551665
@eolivelli do you want to review this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Zhen-hao commented on pull request #11801: [docs] add documentation for Schema.NATIVE_AVRO
Posted by GitBox <gi...@apache.org>.
Zhen-hao commented on pull request #11801:
URL: https://github.com/apache/pulsar/pull/11801#issuecomment-907015825
> Does this affect only master or other versioned docs?
> If latter, could you please help update all affected versions? Thanks
As far as I know, #11238 was not backported to earlier versions. It seems to me that updating `master` is enough.
But you can double-check that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org