You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/21 02:44:12 UTC
[GitHub] sunithabeeram commented on a change in pull request #3535: Optimize
all filter predicates by adding isAlwaysTrue()
sunithabeeram commented on a change in pull request #3535: Optimize all filter predicates by adding isAlwaysTrue()
URL: https://github.com/apache/incubator-pinot/pull/3535#discussion_r235237600
##########
File path: pinot-core/src/main/java/com/linkedin/pinot/core/operator/filter/predicate/NotEqualsPredicateEvaluatorFactory.java
##########
@@ -75,8 +75,12 @@ public static BaseRawValueBasedPredicateEvaluator newRawValueBasedEvaluator(NEqP
_nonMatchingDictId = dictionary.indexOf(nEqPredicate.getNotEqualsValue());
if (_nonMatchingDictId >= 0) {
_nonMatchingDictIds = new int[]{_nonMatchingDictId};
+ if (dictionary.length() == 1) {
Review comment:
Shouldn't this be _nonMatchingIds == dictionary.length()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org