You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:19:19 UTC
[GitHub] [echarts] plainheart opened a new pull request #16820: chore: update release materials, KEYS, README
plainheart opened a new pull request #16820:
URL: https://github.com/apache/echarts/pull/16820
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
- Add NPM install link to the vote-release template as the community suggested
- Update KEYS to latest
- Update the homepage link in package.json to https
- Remove deprecated tutorial link for custom build in README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart merged pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
plainheart merged pull request #16820:
URL: https://github.com/apache/echarts/pull/16820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16820:
URL: https://github.com/apache/echarts/pull/16820#discussion_r840277246
##########
File path: KEYS
##########
@@ -132,3 +132,181 @@ MhfLdHrk689ty11m+5HlrSU7O1I1wZkt/OlYsZmS1yIpD1hEnOuSjAuqm4D3s+YI
B4WM8AJSCwl8WlZrRA==
=wft0
-----END PGP PUBLIC KEY BLOCK-----
+
+pub rsa4096 2020-08-06 [SC]
+ 94BD178077672157652826758E44A82497382298
+uid [ 绝对 ] Shen Yi (CODE SIGNING KEY\) <sh...@apache.org>
Review comment:
I'm not sure if this can be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16820:
URL: https://github.com/apache/echarts/pull/16820#issuecomment-1085515142
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16820:
URL: https://github.com/apache/echarts/pull/16820#discussion_r840276292
##########
File path: KEYS
##########
@@ -132,3 +132,181 @@ MhfLdHrk689ty11m+5HlrSU7O1I1wZkt/OlYsZmS1yIpD1hEnOuSjAuqm4D3s+YI
B4WM8AJSCwl8WlZrRA==
=wft0
-----END PGP PUBLIC KEY BLOCK-----
+
+pub rsa4096 2020-08-06 [SC]
+ 94BD178077672157652826758E44A82497382298
+uid [ 绝对 ] Shen Yi (CODE SIGNING KEY\) <sh...@apache.org>
Review comment:
Seems unexpected Chinese character here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16820:
URL: https://github.com/apache/echarts/pull/16820#issuecomment-1085475453
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16820: chore: update release materials, KEYS, README
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16820:
URL: https://github.com/apache/echarts/pull/16820#discussion_r840283295
##########
File path: KEYS
##########
@@ -132,3 +132,181 @@ MhfLdHrk689ty11m+5HlrSU7O1I1wZkt/OlYsZmS1yIpD1hEnOuSjAuqm4D3s+YI
B4WM8AJSCwl8WlZrRA==
=wft0
-----END PGP PUBLIC KEY BLOCK-----
+
+pub rsa4096 2020-08-06 [SC]
+ 94BD178077672157652826758E44A82497382298
+uid [ 绝对 ] Shen Yi (CODE SIGNING KEY\) <sh...@apache.org>
Review comment:
It can be used to verify the signature successfully now, so let's keep it unchanged. Just noticed and mentioned it a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org