You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by l03wn3 <gi...@git.apache.org> on 2015/04/07 15:22:29 UTC
[GitHub] storm pull request: Add a convenience target to use when debugging...
GitHub user l03wn3 opened a pull request:
https://github.com/apache/storm/pull/510
Add a convenience target to use when debugging topologies locally
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/l03wn3/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/510.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #510
----
commit d89dec6ed44140cc6db05894dff3c1069d6a265b
Author: Nils Loodin <lo...@spotify.com>
Date: 2015-04-07T13:20:32Z
Add a convenience target to use when debugging topologies locally
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by l03wn3 <gi...@git.apache.org>.
Github user l03wn3 commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90723371
Doing
Config conf = new Config();
conf.put(Config.TOPOLOGY_WORKER_CHILDOPTS, "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005");
Doesn't make the JVM suspend upon start and wait for a debugger. Would there be another convenient way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by lazyval <gi...@git.apache.org>.
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90884297
@Parth-Brahmbhatt +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-167629353
@l03wn3, is STORM_JAR_JVM_OPTS OK for debugging this way?
If so, would you close this pull request? Otherwise, would you create a Jira issue for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90728650
@Parth-Brahmbhatt
Maybe @l03wn3 want to attach debugger with main process which submits topology, not deployed workers. But still I agree it doesn't need to add special command.
@l03wn3
If I know "storm.py" right, for now you can try adding your arguments to system environment STORM_JAR_JVM_OPTS before executing "storm jar".
Sure you can restore STORM_JAR_JVM_OPTS after doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by l03wn3 <gi...@git.apache.org>.
Github user l03wn3 commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90841470
@HeartSaVioR Yes, precisely. I've been adding stuff to storm.py and then removing it, but since it's annoying and not convenient to edit the storm binary of the system, I decided to add another target instead. I know there's other less convenient ways, but this is much more convenient and does not require modifying system files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #510: Add a convenience target to use when debugging topologies ...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/510
Closing this. Please reopen if it's still an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #510: Add a convenience target to use when debugging topo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90652646
you could just use the storm jar command and provide the debug args as topology.worker.childopts config. I don't think we need a special command for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Add a convenience target to use when debugging...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/510#issuecomment-90748377
in that case you are right , if you want to test in local mode you should use STORM_JAR_JVM_OPTS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---