You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/25 10:37:38 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

BewareMyPower opened a new pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133


   ### Motivation
   
   When multiple broker clusters shared the same bookie cluster, if user wanted to remove a broker cluster, the associated ledgers in bookies should also be deleted.
   
   ### Modifications
   
   - Add an option to `cluster delete` command to delete all the data associated with the cluster.
   
   Currently there's no way to delete the ledgers of schema from client's side, a new REST API to delete schema's ledgers should be exposed or the existed `SchemaRegistryServiceImpl#deleteSchema`'s semantics should be change. 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   The new option has been tested in local environment by:
   1. Deploy a ZK which acts as both local ZK and the configuration store;
   2. Init metadata of 2 clusters, the 2nd cluster use `--bookkeeper-metadata-service` option to share the same BK metadata position;
   3. Deploy a BK;
   4. Deploy 2 brokers associated with the 2 clusters' metadata;
   5. Create some topics and produce some messages to 2 clusters;
   6. Run `bin/pulsar cluster -all <cluster>` to delete the whole cluster, use `bin/bookkeeper shell list ledgers` to verify the change of ledgers count.
   
   **An integration test is needed to simulate the procedures above.**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699514130


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-698903199


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699608938


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699491330


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-718542627


   need to cherry-pick 2.6.2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699459788


   lgtm， @BewareMyPower would you please open a new issue for the todo item, and linked in your code comments


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699771927


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699637777


   pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699639970


   pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699586684


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699569770


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699614983


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699492037


   @jiazhai I've updated the #8134 to list the TODOs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [WIP][pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699574627


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-698903199


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower removed a comment on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699637777


   pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8133: [pulsar-admin-tools] Support delete all data associated with a cluster

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8133:
URL: https://github.com/apache/pulsar/pull/8133#issuecomment-699806957


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org