You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2021/09/03 09:24:40 UTC

[buildstream] branch tristan/bst-1/fix-external-fork-ci updated (7622b06 -> 754b3c3)

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a change to branch tristan/bst-1/fix-external-fork-ci
in repository https://gitbox.apache.org/repos/asf/buildstream.git.


 discard 7622b06  .github/workflows/ci.yml: Use github concurrency feature instead of branch name globbing
     add d7a4860  tests/cachekey/project/project.conf: Fix cache key test
     add 503bc52  types.py: Add a CoreWarning for unaliased sources
     add 172f90d  source.py: Raise a fatal-able warning when using an unaliased source.
     add 97abc82  source.py: Raise an error at load time when encountering unresolved source aliases
     add 20882c7  tests/frontend/show.py: Test (fatal) warnings for unaliased URLs in sources
     add b162984  Merge pull request #1503 from apache/tristan/bst-1/unaliased-sources
     new 754b3c3  .github/workflows/ci.yml: Use github concurrency feature instead of branch name globbing

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (7622b06)
            \
             N -- N -- N   refs/heads/tristan/bst-1/fix-external-fork-ci (754b3c3)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 buildstream/source.py                             | 20 ++++++++++++++++++++
 buildstream/types.py                              |  6 ++++++
 tests/cachekey/project/project.conf               |  3 +++
 tests/frontend/project/elements/unaliased-tar.bst |  5 +++++
 tests/frontend/show.py                            | 17 +++++++++++++++++
 5 files changed, 51 insertions(+)
 create mode 100644 tests/frontend/project/elements/unaliased-tar.bst

[buildstream] 01/01: .github/workflows/ci.yml: Use github concurrency feature instead of branch name globbing

Posted by tv...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tvb pushed a commit to branch tristan/bst-1/fix-external-fork-ci
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 754b3c3626b4179524d6611b2ba490ff5f48461b
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Mon Aug 30 13:33:45 2021 +0900

    .github/workflows/ci.yml: Use github concurrency feature instead of branch name globbing
    
    The current approach to avoid redundant CI and trigger workflows is preventing
    pull requests from external repositories owned by users that are not in the
    apache github group.
---
 .github/workflows/ci.yml | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 948f6ad..061904e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,23 +1,17 @@
 name: PR Checks
 
-# Run the CI if branches are pushed locally, allowing us to
-# run CI without the need of creating a pull request.
-#
-# Run the CI on pull requests only if they are from forked
-# repositories.
+# Pre-merge CI to run on push and pull_request events, even if this seems
+# redundant, we avoid concurrency with the below configuration.
 #
 on:
   push:
-    branches-ignore:
-    - gh-pages
   pull_request:
-    types: [assigned, opened, synchronize, reopened]
-    branches:
-      # Branches from forks have the form 'user:branch-name' so we only run
-      # this job on pull_request events for branches that look like fork
-      # branches. Without this we would end up running this job twice for non
-      # forked PRs, once for the push and then once for opening the PR.
-    - '**:**'
+
+# Use the concurrency feature to ensure we don't run redundant workflows
+#
+concurrency:
+  group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }}
+  cancel-in-progress: true
 
 jobs:
   tests: