You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2012/06/20 20:06:42 UTC
[jira] [Created] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
ramkrishna.s.vasudevan created HBASE-6246:
---------------------------------------------
Summary: Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
Key: HBASE-6246
URL: https://issues.apache.org/jira/browse/HBASE-6246
Project: HBase
Issue Type: Bug
Components: security
Reporter: ramkrishna.s.vasudevan
{code}
if (destServerName == null || destServerName.length == 0) {
LOG.info("Passed destination servername is null/empty so " +
"choosing a server at random");
this.assignmentManager.clearRegionPlan(hri);
// Unassign will reassign it elsewhere choosing random server.
this.assignmentManager.unassign(hri);
{code}
I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399538#comment-13399538 ]
Hudson commented on HBASE-6246:
-------------------------------
Integrated in HBase-0.94 #271 (See [https://builds.apache.org/job/HBase-0.94/271/])
HBASE-6246. Admin.move without specifying destination does not go through AccessController (rajeshbabu) (Revision 1352981)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399854#comment-13399854 ]
stack commented on HBASE-6246:
------------------------------
@Ted Thanks for catching this (Yeah, if jenkins found the issue, we the reviewers and patch authors should have noticed the problem before you did... thanks for pointing it out)
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399827#comment-13399827 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
+1, we came up with the same addendum. I'll commit it.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6246:
----------------------------------
Attachment: 6246.addendum
Proposed addendum makes TestSplitTransactionOnCluster pass.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399840#comment-13399840 ]
Zhihong Ted Yu commented on HBASE-6246:
---------------------------------------
Normally test suite run for 0.94 isn't strictly required because trunk patch runs through the suite.
In this case, it was not clear whether whole suite was executed by reading the comment @ 22/Jun/12 17:39
Can I make a request ? If a JIRA is only for 0.94 (or 0.92), the contributor or the committer should provide test result similar to the following:
{code}
Failed tests: testRebalanceOnRegionServerNumberChange(org.apache.hadoop.hbase.TestRegionRebalancing): After 5 attempts, region assignments were not balanced.
testOrphanTaskAcquisition(org.apache.hadoop.hbase.master.TestSplitLogManager)
Tests run: 948, Failures: 2, Errors: 0, Skipped: 9
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
{code}
Explanation should be given for the few failed tests.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399839#comment-13399839 ]
Hudson commented on HBASE-6246:
-------------------------------
Integrated in HBase-0.94 #276 (See [https://builds.apache.org/job/HBase-0.94/276/])
Amend HBASE-6246. Admin.move without specifying destination does not go through AccessController
The previous committed change for HBASE-6246 accidentally removed logic
and the omission was caught by TestSplitTransactionOnCluster failures. (Revision 1353063)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400016#comment-13400016 ]
Hudson commented on HBASE-6246:
-------------------------------
Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/])
Amend HBASE-6246. Admin.move without specifying destination does not go through AccessController
The previous committed change for HBASE-6246 accidentally removed logic
and the omission was caught by TestSplitTransactionOnCluster failures. (Revision 1353063)
HBASE-6246. Admin.move without specifying destination does not go through AccessController (rajeshbabu) (Revision 1352981)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399412#comment-13399412 ]
rajeshbabu commented on HBASE-6246:
-----------------------------------
Attached patch 94. Please review and provide comments. TestAccessController passes.
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398885#comment-13398885 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
+1 fix on 0.94. Good catch.
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Labels: coprocessors, security
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman reassigned HBASE-6246:
-----------------------------
Assignee: Laxman
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: Laxman
> Labels: coprocessors, security
> Fix For: 0.94.1
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399894#comment-13399894 ]
ramkrishna.s.vasudevan commented on HBASE-6246:
-----------------------------------------------
@Ted, @Andy and @Stack
Sorry to all. It was me who first let it slip through. Infact we run test suite thro our internal jenkins or if at home either me or Rajesh tries to run the suite.
But yesterday we uploaded the patch and missed on this. I really apologise for my mistake.
Thanks to Ted for pointing it out.
@Andy
Thanks for your patience in preparing addendum and getting it in.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6246:
----------------------------------
Attachment: HBASE-6246_94-addendum.patch
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu reopened HBASE-6246:
-----------------------------------
I was investigating the root cause for frequent TestSplitTransactionOnCluster failures. e.g.:
https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.94/lastCompletedBuild/testReport/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testMasterRestartWhenSplittingIsPartial/
{code}
2012-06-23 02:57:17,388 INFO [Thread-629] regionserver.TestSplitTransactionOnCluster(654): Moving testMasterRestartWhenSplittingIsPartial,,1340420235288.7d985b65a8fb86a516d292158f5d7c40. to vesta.apache.org,34866,1340419933436; metaServerIndex=0
2012-06-23 02:57:17,389 INFO [IPC Server handler 3 on 54803] master.HMaster(1107): Added move plan hri=testMasterRestartWhenSplittingIsPartial,,1340420235288.7d985b65a8fb86a516d292158f5d7c40., src=vesta.apache.org,46324,1340419901533, dest=, running balancer
{code}
We can see clearly that move destination was not picked up by master.
I wonder why the following code was removed in patch for this JIRA ?
{code}
- } else {
- dest = new ServerName(Bytes.toString(destServerName));
{code}
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399418#comment-13399418 ]
stack commented on HBASE-6246:
------------------------------
Fix this:
{code}
+ LOG.info("Passed destination servername is null/empty so " + "choosing a server at random");
{code}
Remove the '+' between the 'so' and 'choosing'.
Else patch looks good.
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu reassigned HBASE-6246:
---------------------------------
Assignee: rajeshbabu (was: Laxman)
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6246:
----------------------------------
Summary: Admin.move without specifying destination does not go through AccessController (was: Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.)
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6246.
--------------------------------
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399829#comment-13399829 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
Committed addendum as r1353063. Thanks for identifying the error Ted.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399422#comment-13399422 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
I have this change staged for commit with the change Stack wants applied also. Running local tests. Will commit if all pass.
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6246:
------------------------------
Attachment: HBASE-6246_94.patch
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399825#comment-13399825 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
@Ted I didn't see/catch this error locally but we can put back accidentally removed logic with an addendum.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-6246.
-----------------------------------
Resolution: Fixed
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-6246.
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed to 0.94 branches. Tests pass locally, including TestAccessController, TestMasterObserver, etc.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-6246:
------------------------------------------
Fix Version/s: 0.94.1
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Labels: coprocessors, security
> Fix For: 0.94.1
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6246) Admin.move without specifying
destination does not go through AccessController
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399845#comment-13399845 ]
Andrew Purtell commented on HBASE-6246:
---------------------------------------
@Ted, two committers looked at this patch and the mistake got through. Yes, that is my fault. However the Jenkins build caught the error. So I thank you for your request and continued attention at pointing out my mistake, but I don't see what needs to happen differently. Perhaps if you still feel differently you can expand on your reasoning.
> Admin.move without specifying destination does not go through AccessController
> ------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Labels: coprocessors, security
> Fix For: 0.94.1
>
> Attachments: 6246.addendum, HBASE-6246_94-addendum.patch, HBASE-6246_94.patch
>
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6246) Admin.move() without specifying
destination calls am.unassign() and does not go through AccessController.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman updated HBASE-6246:
--------------------------
Component/s: coprocessors
Affects Version/s: 0.94.1
0.94.0
Labels: coprocessors security (was: )
Seems to be 0.94 specific issue. Code looks good in trunk.
> Admin.move() without specifying destination calls am.unassign() and does not go through AccessController.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6246
> URL: https://issues.apache.org/jira/browse/HBASE-6246
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, security
> Affects Versions: 0.94.0, 0.94.1
> Reporter: ramkrishna.s.vasudevan
> Labels: coprocessors, security
>
> {code}
> if (destServerName == null || destServerName.length == 0) {
> LOG.info("Passed destination servername is null/empty so " +
> "choosing a server at random");
> this.assignmentManager.clearRegionPlan(hri);
> // Unassign will reassign it elsewhere choosing random server.
> this.assignmentManager.unassign(hri);
> {code}
> I think we should go through security to see if there is sufficient permissions to do this operation?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira