[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

[GitBox <gi...@apache.org>]

pengzhiwei2018 commented on a change in pull request #3126:
URL: https://github.com/apache/hudi/pull/3126#discussion_r659425547



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
##########
@@ -426,7 +426,8 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Runnab
       throw new IllegalArgumentException(s"Merge Key[${targetKey2SourceExpression.keySet.mkString(",")}] is not" +
         s" Equal to the defined primary key[${definedPk.mkString(",")}] in table $targetTableName")
     }
-
+    // Enable the hive sync by default if spark have enable the hive metastore.
+    val enableHive = "hive" == sparkSession.sessionState.conf.getConf(StaticSQLConf.CATALOG_IMPLEMENTATION)

Review comment:
       done!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org