[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1507: [KYUUBI #1499] Introduce DataFrameHolder for cli result fetching

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #1507:
URL: https://github.com/apache/incubator-kyuubi/pull/1507#discussion_r770420113



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/repl/DataFrameHolder.scala
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.spark.repl
+
+import java.util.HashMap
+
+import org.apache.spark.kyuubi.SparkContextHelper
+import org.apache.spark.sql.{DataFrame, SparkSession}
+
+/**
+ * Helper class to wrap a [[DataFrame]] and pass its results to clients
+ *
+ * @since 1.5.0
+ */
+class DataFrameHolder(spark: SparkSession) {
+
+  private val results = new HashMap[String, DataFrame]()
+
+  private def currentId: String = {
+    SparkContextHelper.getCurrentStatementId(spark.sparkContext)
+  }
+
+  /**
+   * Set Results
+   * @param df a DataFrame for pass result to to clients
+   */
+  def set(df: DataFrame): Unit = {

Review comment:
       So these methods are actually used by user ? If user execute some statements in one session, the `DataFrameHolder ` can share the staging dataframe.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org