You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2018/12/18 18:52:44 UTC

[incubator-superset] branch 0.30 updated (f94ed5f -> 7dddc61)

This is an automated email from the ASF dual-hosted git repository.

michellet pushed a change to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


    from f94ed5f  0.30rc1
     new b0f464d  [warm] Enforcing consistent form-data (#6531)
     new 6b5a25a  Avoid resetting margin to 0 (#6536)
     new c9d52ad  adding in a dependency version to fix an error with Flask CLI (#6547)
     new 7dddc61  0.30rc2

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 requirements-dev.txt                               | 2 +-
 superset/assets/package.json                       | 2 +-
 superset/assets/src/visualizations/nvd3/NVD3Vis.js | 6 ++++--
 superset/views/core.py                             | 8 +++++++-
 4 files changed, 13 insertions(+), 5 deletions(-)


[incubator-superset] 04/04: 0.30rc2

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 7dddc61e55dc9b9e23e635cf6604dc2fea573e0b
Author: Michelle Thomas <mi...@gmail.com>
AuthorDate: Tue Dec 18 10:51:43 2018 -0800

    0.30rc2
---
 superset/assets/package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/package.json b/superset/assets/package.json
index adc3773..2f41286 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -1,6 +1,6 @@
 {
   "name": "superset",
-  "version": "0.29.0rc1",
+  "version": "0.29.0rc2",
   "description": "Superset is a data exploration platform designed to be visual, intuitive, and interactive.",
   "license": "Apache-2.0",
   "directories": {


[incubator-superset] 01/04: [warm] Enforcing consistent form-data (#6531)

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit b0f464d7313f93d30b3cdc9a85e4bea5567134e0
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri Dec 14 14:00:38 2018 +1300

    [warm] Enforcing consistent form-data (#6531)
    
    (cherry picked from commit 1fba6f7a174a275cd8ed33367fe4d3932301b9ea)
---
 superset/views/core.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 7faa1e2..f9eb299 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2050,7 +2050,13 @@ class Superset(BaseSupersetView):
 
         for slc in slices:
             try:
-                obj = slc.get_viz(force=True)
+                form_data = self.get_form_data(slc.id, use_slice_data=True)[0]
+                obj = self.get_viz(
+                    datasource_type=slc.datasource.type,
+                    datasource_id=slc.datasource.id,
+                    form_data=form_data,
+                    force=True,
+                )
                 obj.get_json()
             except Exception as e:
                 return json_error_response(utils.error_msg_from_exception(e))


[incubator-superset] 02/04: Avoid resetting margin to 0 (#6536)

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 6b5a25a38540af4954e154d9c4fb14a17203b2d3
Author: michellethomas <mi...@gmail.com>
AuthorDate: Fri Dec 14 14:17:45 2018 -0800

    Avoid resetting margin to 0 (#6536)
    
    * Avoid resetting margin to 0
    
    * Fixing margin for pie chart
    
    (cherry picked from commit fe0f5e968e8ad42dcc24c13f9aef0d3c58226d37)
---
 superset/assets/src/visualizations/nvd3/NVD3Vis.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset/assets/src/visualizations/nvd3/NVD3Vis.js b/superset/assets/src/visualizations/nvd3/NVD3Vis.js
index 5fbfed0..1a72303 100644
--- a/superset/assets/src/visualizations/nvd3/NVD3Vis.js
+++ b/superset/assets/src/visualizations/nvd3/NVD3Vis.js
@@ -353,6 +353,8 @@ function nvd3Vis(element, props) {
             chart.labelType(d => `${d.data.x}: ${((d.data.y / total) * 100).toFixed()}%`);
           }
         }
+        // Pie chart does not need top margin
+        chart.margin({ top: 0 });
         break;
 
       case 'column':
@@ -407,8 +409,8 @@ function nvd3Vis(element, props) {
       default:
         throw new Error('Unrecognized visualization for nvd3' + vizType);
     }
-    // Assuming the container has padding already
-    chart.margin({ top: 0, left: 0, right: 0, bottom: 0 });
+    // Assuming the container has padding already other than for top margin
+    chart.margin({ left: 0, right: 0, bottom: 0 });
 
     if (showBarValue) {
       setTimeout(function () {


[incubator-superset] 03/04: adding in a dependency version to fix an error with Flask CLI (#6547)

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch 0.30
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit c9d52ad6e7eb9ef0e29f1c1293b74d875cb478c3
Author: Marcus <ma...@gmail.com>
AuthorDate: Mon Dec 17 22:46:04 2018 +0100

    adding in a dependency version to fix an error with Flask CLI (#6547)
    
    (cherry picked from commit 9ec3e18ecb6c183237d859919af4daea7893b897)
---
 requirements-dev.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/requirements-dev.txt b/requirements-dev.txt
index 0b991fc..53dcbe7 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -1,5 +1,5 @@
 console_log==0.2.10
-python-dotenv
+python-dotenv==0.10.1
 flake8-commas==2.0.0
 flake8-import-order==0.18
 flake8-quotes==1.0.0