You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/15 15:32:12 UTC

[GitHub] attilapiros opened a new pull request #23801: [SPARK-26891][YARN] Fixing flaky test YarnSchedulerBackendSuite

attilapiros opened a new pull request #23801: [SPARK-26891][YARN] Fixing flaky test YarnSchedulerBackendSuite
URL: https://github.com/apache/spark/pull/23801
 
 
   ## What changes were proposed in this pull request?
   
   The test "RequestExecutors reflects node blacklist and is serializable" is flaky because of multi threaded access of the mock task scheduler. For details check [Mockito FAQ (occasional exceptions like: WrongTypeOfReturnValue)](https://github.com/mockito/mockito/wiki/FAQ#is-mockito-thread-safe). So instead of mocking the task scheduler in the test TaskSchedulerImpl is simply subclassed.
   
   ## How was this patch tested?
   
   Existing unittest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org