You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by pk...@apache.org on 2022/11/14 18:00:45 UTC
[incubator-nuttx-apps] branch master updated: dhcpc:disable broadcast flag in DHCP process
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 4c5406e22 dhcpc:disable broadcast flag in DHCP process
4c5406e22 is described below
commit 4c5406e2256a0a49bfe0373bad33d1b9dd698c45
Author: liangchaozhong <li...@xiaomi.com>
AuthorDate: Mon Nov 14 22:19:08 2022 +0800
dhcpc:disable broadcast flag in DHCP process
Issue:
DHCP server will send DHCP offer/ack via broadcast packet if broadcast
flag is enabled in DHCP discover/request.
There's no retransmition mechanism for broadcast frame in 802.11 MAC
layer, thus transmit fail rate might be very high. This will increase DHCP fail rate.
Solution:
Disable broadcast flag by default
Signed-off-by: liangchaozhong <li...@xiaomi.com>
---
netutils/dhcpc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netutils/dhcpc/Kconfig b/netutils/dhcpc/Kconfig
index 49e55856c..2862e0ce7 100644
--- a/netutils/dhcpc/Kconfig
+++ b/netutils/dhcpc/Kconfig
@@ -32,7 +32,7 @@ config NETUTILS_DHCPC_RETRIES
config NETUTILS_DHCPC_BOOTP_FLAGS
hex "Flags of Bootstrap"
- default 0x8000
+ default 0x0000
---help---
This setting to set the BOOTP broadcast flags.
Reference RFC1542: Clarifications and Extensions for the