You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2018/01/16 06:52:02 UTC

zeppelin git commit: ZEPPELIN-3166. R plotting resolution and image width is not proper

Repository: zeppelin
Updated Branches:
  refs/heads/master aa5deb968 -> 0418267a3


ZEPPELIN-3166. R plotting resolution and image width is not proper

### What is this PR for?
Change the resolution and image width, because the previous default value is not proper.

By adding `fig.retina = 2` for high resolution. And use `40%` as default image width.

### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3166

### How should this be tested?
* Manually verfifed

### Screenshots (if appropriate)

Before

![screen shot 2018-01-15 at 2 27 01 pm](https://user-images.githubusercontent.com/164491/34930418-46680e38-fa04-11e7-9b73-b12bd61986f2.png)

After

![screen shot 2018-01-15 at 2 27 11 pm](https://user-images.githubusercontent.com/164491/34930430-509204e0-fa04-11e7-927c-c9b4982f8373.png)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Jeff Zhang <zj...@apache.org>

Closes #2730 from zjffdu/ZEPPELIN-3166 and squashes the following commits:

97861c2 [Jeff Zhang] ZEPPELIN-3166. R plotting resolution and image width is not proper


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0418267a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0418267a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0418267a

Branch: refs/heads/master
Commit: 0418267a3d6eadac10292f00bad1830e93e3d423
Parents: aa5deb9
Author: Jeff Zhang <zj...@apache.org>
Authored: Mon Jan 15 14:53:54 2018 +0800
Committer: Jeff Zhang <zj...@apache.org>
Committed: Tue Jan 16 14:51:56 2018 +0800

----------------------------------------------------------------------
 spark/src/main/resources/interpreter-setting.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0418267a/spark/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/spark/src/main/resources/interpreter-setting.json b/spark/src/main/resources/interpreter-setting.json
index f98bd72..f45c85c 100644
--- a/spark/src/main/resources/interpreter-setting.json
+++ b/spark/src/main/resources/interpreter-setting.json
@@ -213,7 +213,7 @@
       "zeppelin.R.render.options": {
         "envName": "ZEPPELIN_R_RENDER_OPTIONS",
         "propertyName": "zeppelin.R.render.options",
-        "defaultValue": "out.format = 'html', comment = NA, echo = FALSE, results = 'asis', message = F, warning = F",
+        "defaultValue": "out.format = 'html', comment = NA, echo = FALSE, results = 'asis', message = F, warning = F, fig.retina = 2",
         "description": "",
         "type": "textarea"
       }