You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/07/31 17:47:54 UTC
[GitHub] merlimat closed pull request #2267: Open site links in new windows
merlimat closed pull request #2267: Open site links in new windows
URL: https://github.com/apache/incubator-pulsar/pull/2267
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/site2/website/core/Footer.js b/site2/website/core/Footer.js
index 622072b70b..40f21c41ce 100644
--- a/site2/website/core/Footer.js
+++ b/site2/website/core/Footer.js
@@ -125,16 +125,17 @@ class Footer extends React.Component {
const communityMenuJs = `
const community = document.querySelector("a[href='#community']").parentNode;
- const communityMenu =
+ const communityMenu =
'<li>' +
- '<a id="community-menu" href="#">Community</a>' +
+ '<a id="community-menu" href="#">Community <span style="font-size: 0.75em"> ▼</span></a>' +
'<div id="community-dropdown" class="hide">' +
'<ul id="community-dropdown-items">' +
- '<li><a href="${contactUrl}">Contant</a></li>' +
+ '<li><a href="${contactUrl}">Contact</a></li>' +
'<li><a href="${eventsUrl}">Events</a></li>' +
- '<li><a href="${twitterUrl}">Twitter</a></li>' +
- '<li><a href="${wikiUrl}">Wiki</a></li>' +
- '<li><a href="${issuesUrl}">Issue tracking</a></li>' +
+ '<li><a href="${twitterUrl}" target="_blank">Twitter ❐</a></li>' +
+ '<li><a href="${wikiUrl}" target="_blank">Wiki ❐</a></li>' +
+ '<li><a href="${issuesUrl}" target="_blank">Issue tracking ❐</a></li>' +
+ '<li> </li>' +
'<li><a href="${resourcesUrl}">Resources</a></li>' +
'<li><a href="${teamUrl}">Team</a></li>' +
'</ul>' +
diff --git a/site2/website/pages/en/contact.js b/site2/website/pages/en/contact.js
index 1bda91e19b..7935924466 100644
--- a/site2/website/pages/en/contact.js
+++ b/site2/website/pages/en/contact.js
@@ -68,12 +68,12 @@ class Contact extends React.Component {
<hr />
</header>
<p>
- There are many ways to get help from the Apache Pulsar community.
- The mailing lists are the primary place where all Pulsar committers are present.
- Bugs and feature requests can either be discussed on the dev mailing list or
- by opening an issue on <a href="">GitHub</a>.
+ There are many ways to get help from the Apache Pulsar community.
+ The mailing lists are the primary place where all Pulsar committers are present.
+ Bugs and feature requests can either be discussed on the dev mailing list or
+ by opening an issue on <a href="https://github.com/apache/incubator-pulsar/" target="_blank">GitHub</a>.
</p>
-
+
<h2>Mailing Lists</h2>
<table className="versions">
<thead>
@@ -102,12 +102,12 @@ class Contact extends React.Component {
<h2>Slack</h2>
<p>There is a Pulsar slack channel that is used for informal discussions for devs and users.</p>
- <MarkdownBlock>
- The Slack instance is at [https://apache-pulsar.slack.com/](https://apache-pulsar.slack.com/)
- </MarkdownBlock>
- <MarkdownBlock>
- You can self-register at [https://apache-pulsar.herokuapp.com/](https://apache-pulsar.herokuapp.com/)
- </MarkdownBlock>
+
+ <p>The Slack instance is at <a href="https://apache-pulsar.slack.com/" target="_blank">
+ https://apache-pulsar.slack.com/</a></p>
+
+ <p>You can self-register at <a href="https://apache-pulsar.herokuapp.com/" target="_blank">
+ https://apache-pulsar.herokuapp.com/</a></p>
</div>
</Container>
</div>
diff --git a/site2/website/static/js/custom.js b/site2/website/static/js/custom.js
index 96f5e5598f..15eaa9af9d 100644
--- a/site2/website/static/js/custom.js
+++ b/site2/website/static/js/custom.js
@@ -4,9 +4,9 @@ window.addEventListener('load', function() {
// setup apache menu items in nav bar
/*const community = document.querySelector("a[href='#community']").parentNode;
- const communityMenu =
+ const communityMenu =
'<li>' +
- '<a id="community-menu" href="#">Community</a>' +
+ '<a id="community-menu" href="#">Community</a>' +
'<div id="community-dropdown" class="hide">' +
'<ul id="community-dropdown-items">' +
'<li><a href="/contact">Contant</a></li>' +
@@ -36,16 +36,16 @@ window.addEventListener('load', function() {
// setup apache menu items in nav bar
const apache = document.querySelector("a[href='#apache']").parentNode;
- const apacheMenu =
+ const apacheMenu =
'<li>' +
- '<a id="apache-menu" href="#">Apache</a>' +
+ '<a id="apache-menu" href="#">Apache <span style="font-size: 0.75em"> ▼</span></a>' +
'<div id="apache-dropdown" class="hide">' +
'<ul id="apache-dropdown-items">' +
- '<li><a href="https://www.apache.org/">Foundation</a></li>' +
- '<li><a href="https://www.apache.org/licenses/">License</a></li>' +
- '<li><a href="https://www.apache.org/foundation/sponsorship.html">Sponsorship</a></li>' +
- '<li><a href="https://www.apache.org/foundation/thanks.html">Thanks</a></li>' +
- '<li><a href="https://www.apache.org/security">Security</a></li>' +
+ '<li><a href="https://www.apache.org/" target="_blank" >Foundation ❐</a></li>' +
+ '<li><a href="https://www.apache.org/licenses/" target="_blank">License ❐</a></li>' +
+ '<li><a href="https://www.apache.org/foundation/sponsorship.html" target="_blank">Sponsorship ❐</a></li>' +
+ '<li><a href="https://www.apache.org/foundation/thanks.html" target="_blank">Thanks ❐</a></li>' +
+ '<li><a href="https://www.apache.org/security" target="_blank">Security ❐</a></li>' +
'</ul>' +
'</div>' +
'</li>';
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services