You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zhhyu7 (via GitHub)" <gi...@apache.org> on 2023/05/04 05:19:53 UTC

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9175: netlink: convert lltype to device type

zhhyu7 opened a new pull request, #9175:
URL: https://github.com/apache/nuttx/pull/9175

   ## Summary
   We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data types do not match the expectations. Refer to the common implementation of other systems and add relevant definitions.
   ## Impact
   
   ## Testing
   sim:local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9175: netlink: convert lltype to device type

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9175:
URL: https://github.com/apache/nuttx/pull/9175#discussion_r1184898805


##########
net/netlink/netlink_route.c:
##########
@@ -246,6 +247,44 @@ static_assert(sizeof(g_ifa_ipv6_policy) / sizeof(g_ifa_ipv6_policy[0]) ==
  ****************************************************************************/
 
 #ifndef CONFIG_NETLINK_DISABLE_GETLINK
+
+uint16_t netlink_convert_device_type(uint8_t lltype)

Review Comment:
   add static



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 merged pull request #9175: netlink: convert lltype to device type

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9175:
URL: https://github.com/apache/nuttx/pull/9175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] zhhyu7 commented on a diff in pull request #9175: netlink: convert lltype to device type

Posted by "zhhyu7 (via GitHub)" <gi...@apache.org>.
zhhyu7 commented on code in PR #9175:
URL: https://github.com/apache/nuttx/pull/9175#discussion_r1184913611


##########
net/netlink/netlink_route.c:
##########
@@ -246,6 +247,44 @@ static_assert(sizeof(g_ifa_ipv6_policy) / sizeof(g_ifa_ipv6_policy[0]) ==
  ****************************************************************************/
 
 #ifndef CONFIG_NETLINK_DISABLE_GETLINK
+
+uint16_t netlink_convert_device_type(uint8_t lltype)

Review Comment:
   > add static
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org