You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "houxinlin (via GitHub)" <gi...@apache.org> on 2023/04/27 14:40:00 UTC
[GitHub] [skywalking-java] houxinlin opened a new pull request, #518: Support tencent sms
houxinlin opened a new pull request, #518:
URL: https://github.com/apache/skywalking-java/pull/518
1. Support tencent sms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #518: Support tencent sms
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #518: Support tencent sms
URL: https://github.com/apache/skywalking-java/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525941418
> > > Hi, first of all, thanks for your consideration of the contribution. But I am afraid that, we can't accept this. We don't have change to verify this plugin especially in CI process, which is required by all plugins. Meanwhile, we don't have a single one committer from Tencent cloud, which means no committer could verify this.
> >
> >
> > >
> >
> >
> > > It may be better you could host and release on your own repository.
> >
> >
> > I would like to contribute a skywalking API to provide a query interface. Does the community need it?
>
> Could you elaborate on what it does? I see you have a repo for that but there isn't code yet.
Yes, our project used skywalking, but we need to use Java code to query the data in skywalking, such as service and trace. I couldn't find a very useful library, so I came up with this idea and only provided an interface to directly query the necessary data from h2, es, and MySQL, not just through skywalking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525961053
> Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
I'm sorry to initiate a discussion at this time and disturb your rest
> Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
I'm sorry to initiate a discussion at this time and disturb your rest,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525949032
> Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
Yes, sometimes we need to continue querying data directly from the database when skywalking is not started or there are exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #518: Support tencent sms
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525944478
Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525916800
> Hi, first of all, thanks for your consideration of the contribution. But I am afraid that, we can't accept this. We don't have change to verify this plugin especially in CI process, which is required by all plugins. Meanwhile, we don't have a single one committer from Tencent cloud, which means no committer could verify this.
>
> It may be better you could host and release on your own repository.
Okay, I understand. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #518: Support tencent sms
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525905119
Hi, first of all, thanks for your consideration of the contribution.
But I am afraid that, we can't accept this.
We don't have change to verify this plugin especially in CI process, which is required by all plugins.
Meanwhile, we don't have a single one committer from Tencent cloud, which means no committer could verify this.
It may be better you could host and release on your own repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525924787
> Hi, first of all, thanks for your consideration of the contribution. But I am afraid that, we can't accept this. We don't have change to verify this plugin especially in CI process, which is required by all plugins. Meanwhile, we don't have a single one committer from Tencent cloud, which means no committer could verify this.
>
> It may be better you could host and release on your own repository.
I would like to contribute a skywalking API to provide a query interface. Does the community need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] houxinlin commented on pull request #518: Support tencent sms
Posted by "houxinlin (via GitHub)" <gi...@apache.org>.
houxinlin commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1526833784
> > > Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
> >
> >
> > Yes, sometimes we need to continue querying data directly from the database when skywalking is not started or there are exceptions
>
> Please open a discussion about your new proposal.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #518: Support tencent sms
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525988084
> > Isn't GraphQL designed for this? Are you suggesting a kind of Java SDK?
>
>
>
> Yes, sometimes we need to continue querying data directly from the database when skywalking is not started or there are exceptions
Please open a discussion about your new proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Superskyyy commented on pull request #518: Support tencent sms
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #518:
URL: https://github.com/apache/skywalking-java/pull/518#issuecomment-1525933656
> > Hi, first of all, thanks for your consideration of the contribution. But I am afraid that, we can't accept this. We don't have change to verify this plugin especially in CI process, which is required by all plugins. Meanwhile, we don't have a single one committer from Tencent cloud, which means no committer could verify this.
>
> >
>
> > It may be better you could host and release on your own repository.
>
>
>
> I would like to contribute a skywalking API to provide a query interface. Does the community need it?
Could you elaborate on what it does? I see you have a repo for that but there isn't code yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org