[GitHub] [couchdb-docker] kocolosk commented on a change in pull request #165: dev: debian-buster, node 10, SM60

[GitBox <gi...@apache.org>]

kocolosk commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375025233
 
 

 ##########
 File path: dev/Dockerfile
 ##########
 @@ -111,16 +111,16 @@ RUN pip3 install --upgrade \
 # Node is special
 RUN set -ex; \
     curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -; \
-    echo 'deb https://deb.nodesource.com/node_8.x stretch main' > /etc/apt/sources.list.d/nodesource.list; \
-    echo 'deb-src https://deb.nodesource.com/node_8.x stretch main' >> /etc/apt/sources.list.d/nodesource.list; \
+    echo 'deb https://deb.nodesource.com/node_10.x buster main' > /etc/apt/sources.list.d/nodesource.list; \
+    echo 'deb-src https://deb.nodesource.com/node_10.x buster main' >> /etc/apt/sources.list.d/nodesource.list; \
     apt-get update -y && apt-get install -y nodejs; \
     npm install -g grunt-cli
 
 # Clone CouchDB source code including all dependencies
 ARG clone_url=https://github.com/apache/couchdb.git
 RUN git clone $clone_url /usr/src/couchdb
 WORKDIR /usr/src/couchdb
-RUN ./configure
+RUN ./configure -c --spidermonkey-version 60
 
 Review comment:
   Not sure adding the flags here was required; this invocation is only here to download base versions of dependencies to speed up subsequent builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services