You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/12 05:38:13 UTC
[GitHub] [incubator-nuttx] eenurkka opened a new pull request, #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
eenurkka opened a new pull request, #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075
Some related products, such as Aries m100pfs, don't support eMMC speeds up to 200MHz. Thus, provide option to select slower clock. This has only to do with the clocking, no CMD6 is sent to select high speed modes.
Signed-off-by: Eero Nurkkala <ee...@offcode.fi>
## Summary
Allow selecting the eMMC clock speed.
## Impact
MPFS Polarfire / Aries
## Testing
MPFS polarfire kit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r968016845
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -250,6 +250,33 @@ config MPFS_EMMCSD
---help---
Selects the MPFS eMMCSD driver.
+choice
+ depends on MPFS_EMMCSD && MMCSD_MMCSUPPORT
+ prompt "Configure eMMC clock speed"
+ ---help---
+ Select the desired eMMC clock frequency. This doesn't issue any CMD6 commands to
+ switch the mode at the moment. This only changes the eMMC clock. Not all hardware
+ support 200 MHz but the Polarfire Icicle kit does.
+
+config MPFS_EMMC_CLK_200MHZ
+ bool "EMMC CLK 200MHz"
+ default y
+ ---help---
+ Set this to use 200MHz eMMC clock
+
+config MPFS_EMMC_CLK_50MHZ
+ bool "EMMC CLK 50MHz"
+ default n
+ ---help---
+ Set this to use 50MHz eMMC clock
+
+config MPFS_EMMC_CLK_26MHZ
+ bool "EMMC CLK 26MHz"
+ default n
+ ---help---
+ Set this to use 26MHz eMMC clock
+endchoice
Review Comment:
Maybe this can be just a define from `board.h`? I mean that IMO clocking selection is very similar to GPIO selection and can be handled in a similar way. What do you think? Unless there is a plan to witch between CLK speed for the sam board at compile time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
eenurkka commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r968034493
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -250,6 +250,33 @@ config MPFS_EMMCSD
---help---
Selects the MPFS eMMCSD driver.
+choice
+ depends on MPFS_EMMCSD && MMCSD_MMCSUPPORT
+ prompt "Configure eMMC clock speed"
+ ---help---
+ Select the desired eMMC clock frequency. This doesn't issue any CMD6 commands to
+ switch the mode at the moment. This only changes the eMMC clock. Not all hardware
+ support 200 MHz but the Polarfire Icicle kit does.
+
+config MPFS_EMMC_CLK_200MHZ
+ bool "EMMC CLK 200MHz"
+ default y
+ ---help---
+ Set this to use 200MHz eMMC clock
+
+config MPFS_EMMC_CLK_50MHZ
+ bool "EMMC CLK 50MHz"
+ default n
+ ---help---
+ Set this to use 50MHz eMMC clock
+
+config MPFS_EMMC_CLK_26MHZ
+ bool "EMMC CLK 26MHz"
+ default n
+ ---help---
+ Set this to use 26MHz eMMC clock
+endchoice
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r970391739
##########
boards/risc-v/mpfs/icicle/include/board.h:
##########
@@ -37,6 +37,10 @@
* Pre-processor Definitions
****************************************************************************/
+#if defined(CONFIG_MMCSD_MMCSUPPORT) && defined(CONFIG_MPFS_EMMCSD)
+#define MPFS_EMMC_CLK_200MHZ
Review Comment:
```suggestion
# define MPFS_EMMC_CLK_MODE MPFS_EMMCSD_MODE_HS200
```
and simplify code in `mpfs_device_reset` by`priv->bus_speed = MPFS_EMMC_CLK_MODE;`?
```
priv->bus_speed = MPFS_EMMC_CLK_MODE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
eenurkka commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r970564962
##########
boards/risc-v/mpfs/icicle/include/board.h:
##########
@@ -37,6 +37,10 @@
* Pre-processor Definitions
****************************************************************************/
+#if defined(CONFIG_MMCSD_MMCSUPPORT) && defined(CONFIG_MPFS_EMMCSD)
+#define MPFS_EMMC_CLK_200MHZ
Review Comment:
Right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r968016845
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -250,6 +250,33 @@ config MPFS_EMMCSD
---help---
Selects the MPFS eMMCSD driver.
+choice
+ depends on MPFS_EMMCSD && MMCSD_MMCSUPPORT
+ prompt "Configure eMMC clock speed"
+ ---help---
+ Select the desired eMMC clock frequency. This doesn't issue any CMD6 commands to
+ switch the mode at the moment. This only changes the eMMC clock. Not all hardware
+ support 200 MHz but the Polarfire Icicle kit does.
+
+config MPFS_EMMC_CLK_200MHZ
+ bool "EMMC CLK 200MHz"
+ default y
+ ---help---
+ Set this to use 200MHz eMMC clock
+
+config MPFS_EMMC_CLK_50MHZ
+ bool "EMMC CLK 50MHz"
+ default n
+ ---help---
+ Set this to use 50MHz eMMC clock
+
+config MPFS_EMMC_CLK_26MHZ
+ bool "EMMC CLK 26MHz"
+ default n
+ ---help---
+ Set this to use 26MHz eMMC clock
+endchoice
Review Comment:
Maybe this can be just a define from `board.h`? I mean that IMO clocking selection is very similar to GPIO selection and can be handled in a similar way. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed
Posted by GitBox <gi...@apache.org>.
eenurkka commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r968022878
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -250,6 +250,33 @@ config MPFS_EMMCSD
---help---
Selects the MPFS eMMCSD driver.
+choice
+ depends on MPFS_EMMCSD && MMCSD_MMCSUPPORT
+ prompt "Configure eMMC clock speed"
+ ---help---
+ Select the desired eMMC clock frequency. This doesn't issue any CMD6 commands to
+ switch the mode at the moment. This only changes the eMMC clock. Not all hardware
+ support 200 MHz but the Polarfire Icicle kit does.
+
+config MPFS_EMMC_CLK_200MHZ
+ bool "EMMC CLK 200MHz"
+ default y
+ ---help---
+ Set this to use 200MHz eMMC clock
+
+config MPFS_EMMC_CLK_50MHZ
+ bool "EMMC CLK 50MHz"
+ default n
+ ---help---
+ Set this to use 50MHz eMMC clock
+
+config MPFS_EMMC_CLK_26MHZ
+ bool "EMMC CLK 26MHz"
+ default n
+ ---help---
+ Set this to use 26MHz eMMC clock
+endchoice
Review Comment:
In this case it'd simplify things, I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org