You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/09 00:45:34 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39448: [SPARK-41943][CORE] Use java api to create files and grant permissions

HyukjinKwon commented on code in PR #39448:
URL: https://github.com/apache/spark/pull/39448#discussion_r1064230294


##########
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala:
##########
@@ -301,9 +301,6 @@ private[spark] class DiskBlockManager(
    * Create a directory that is writable by the group.
    * Grant the permission 770 "rwxrwx---" to the directory so the shuffle server can
    * create subdirs/files within the merge folder.
-   * TODO: Find out why can't we create a dir using java api with permission 770

Review Comment:
   Mind summarizing why we can use this approach while the JDK issue isn't resolved?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org