You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/11/18 02:18:33 UTC

[GitHub] [ozone] prashantpogde commented on a change in pull request #1555: HDDS-4347.Make Ozone specific Trash remover multi threaded

prashantpogde commented on a change in pull request #1555:
URL: https://github.com/apache/ozone/pull/1555#discussion_r525648887



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
##########
@@ -206,19 +210,19 @@ private void checkInvalidPath(Path path) throws Exception {
     }
   }
 
-  @Test(timeout = 300_000)
+  @Test(timeout = 540_000)
   public void testFileSystem() throws Exception {
     setupOzoneFileSystem();
 
     testOzoneFsServiceLoader();
     o3fs = (OzoneFileSystem) fs;
 
-    testCreateFileShouldCheckExistenceOfDirWithSameName();
+  /*  testCreateFileShouldCheckExistenceOfDirWithSameName();

Review comment:
       why are these tests commented out ?

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1228,17 +1238,61 @@ public void restart() throws IOException {
       // Allow OM to start as Http Server failure is not fatal.
       LOG.error("OM HttpServer failed to start.", ex);
     }
-
     omRpcServer.start();
+
     isOmRpcServerRunning = true;
 
+    if (isLeader()) {

Review comment:
       this check should be inside run method in TrashPolicyOzone. I also do not see a problem if it was run on all OM nodes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org