You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/23 02:32:32 UTC
[GitHub] [tvm] areusch opened a new pull request, #12880: [usmp] Also remap VarNode to USMP-allocated buffer
areusch opened a new pull request, #12880:
URL: https://github.com/apache/tvm/pull/12880
* Fixes cases where a USMP buffer is used with tensorization intrinsics. In these cases, the buffer data var is referenced directly in the call_extern args.
Before this patch, ConvertPoolAllocationsToOffsets would generate TIR like the following:
let dense_let: Pointer(global int32) = @tir.address_of(global_workspace_37_buffer_var[69952], dtype=handle)
for (k.outer: int32, 0, 64) {
@tir.call_extern("gemm_1x1x1_update_UKVNAEBL", ..., dense, ...)
}
T_multiply[ax1] = @tir.q_multiply_shift(((dense: Buffer(dense_let,
int32, [10], [], align=32)[ax1], ...)
This caused CodegenSourceBase to later fail with this error:
"src/target/source/codegen_source_base.cc", line 67
Check failed: (it != var_idmap_.end()) is false: Find undefined
Variable dense
After this patch, "dense" in the call_extern is changed to read "dense_let."
cc @lhutton1 @Mousius @leandron @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
areusch merged PR #12880:
URL: https://github.com/apache/tvm/pull/12880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
manupak commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1260143073
to clarify a bit more -- I just meant to say, according to https://github.com/apache/tvm/blob/main/docs/contribute/pull_request.rst, we might want to put a textual description in here in the body as the test in the PR shows what is being fixed. Also I think we can remove the first bullet point too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1258706889
@manupak great, deleted the LOG lines and added a test. please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
manupak commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1257720475
Thanks for the fix -- yea I double checked whether buffer info extraction captures this scenario as well -- it seems so. If we can get the tests and LOG(INFO)s removed -- I think we cant get this in...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1256813614
@manupak I think it's ok to pass the buffer's `data` var, since the receiving function expects `T.handle` and will build its own Buffer around it, no? wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
manupak commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1260054391
I think we need a commit message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
manupak commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1256338295
Hmmmm... I suppose this scenario want to pass a buffer itself to the call (as opposed to a BufferLoad) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1255740385
NOTE: sending this through CI to see what I broke, then will add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1260165392
gotcha, updated the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1255956949
also cc @d-smirnov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12880:
URL: https://github.com/apache/tvm/pull/12880#issuecomment-1255742179
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end--><!--bot-comment-skipped-tests-start-->
* No additional skipped tests found in this branch for commit 98798c709efee7fc74c436115a828e14621a80e0.<!--bot-comment-skipped-tests-end--><!--bot-comment-docs-start-->
* Built docs for commit 98798c709efee7fc74c436115a828e14621a80e0 can be found [here](https://pr-docs.tlcpack.ai/PR-12880/1/docs/index.html).<!--bot-comment-docs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org