[GitHub] [arrow-datafusion] andygrove commented on issue #4198: What happened for NDJSON support on CLI?

[GitBox <gi...@apache.org>]

andygrove commented on issue #4198:
URL: https://github.com/apache/arrow-datafusion/issues/4198#issuecomment-1313914426

   There have been changes in how table providers are registered so this is likely a regression. It would be good to get some regression tests added when we fix this.
   
   I am guessing that the fix is simply to add `NDJSON` to this code in datafusion-cli:
   
   ```rust
   fn create_runtime_env() -> Result<RuntimeEnv> {
       let mut table_factories: HashMap<String, Arc<dyn TableProviderFactory>> =
           HashMap::new();
       table_factories.insert(
           "csv".to_string(),
           Arc::new(ListingTableFactory::new(FileType::CSV)),
       );
       table_factories.insert(
           "parquet".to_string(),
           Arc::new(ListingTableFactory::new(FileType::PARQUET)),
       );
       table_factories.insert(
           "avro".to_string(),
           Arc::new(ListingTableFactory::new(FileType::AVRO)),
       );
       table_factories.insert(
           "json".to_string(),
           Arc::new(ListingTableFactory::new(FileType::JSON)),
       );
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org