[GitHub] ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper
URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177471484
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeper.java
 ##########
 @@ -210,6 +213,66 @@ public void close() throws InterruptedException, BKException {
         shutdown();
     }
 
+    @Override
+    public OpenBuilder newOpenLedgerOp() {
+        return new OpenBuilder() {
+            long ledgerId;
+            byte[] password;
+            org.apache.bookkeeper.client.api.DigestType digestType;
+
+            @Override
+            public OpenBuilder withLedgerId(long ledgerId) {
+                this.ledgerId = ledgerId;
+                return this;
+            }
+
+            @Override
+            public OpenBuilder withRecovery(boolean recovery) {
+                return this;
 
 Review comment:
   if needed. currently the mock calls asyncOpenLedger for asyncOpenNoRecovery. 
   
   Originally this code comes from pulsar, where they don't use tailing anyhow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services