You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2011/05/11 02:54:47 UTC
[jira] [Created] (MYFACES-3134) Move all code related to state
caching into one place
Move all code related to state caching into one place
-----------------------------------------------------
Key: MYFACES-3134
URL: https://issues.apache.org/jira/browse/MYFACES-3134
Project: MyFaces Core
Issue Type: Sub-task
Components: JSR-314
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe
It is necessary to do some cleanup and add more junit tests to state saving code in MyFaces.
For PSS code, we just copied some parts of the original algorithm found on JspStateManagerImpl because just PSS was a very challenging task and the intention was prevent break existing code.
But now we have a stable code in this part, so it is the right moment to do some cleanup and then change the code to fit user's needs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3134) Move all code related to state
caching into one place
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-3134.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
2.0.6
> Move all code related to state caching into one place
> -----------------------------------------------------
>
> Key: MYFACES-3134
> URL: https://issues.apache.org/jira/browse/MYFACES-3134
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.6, 2.1.0
>
> Attachments: MYFACES-3134-2.patch
>
>
> It is necessary to do some cleanup and add more junit tests to state saving code in MyFaces.
> For PSS code, we just copied some parts of the original algorithm found on JspStateManagerImpl because just PSS was a very challenging task and the intention was prevent break existing code.
> But now we have a stable code in this part, so it is the right moment to do some cleanup and then change the code to fit user's needs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3134) Move all code related to state
caching into one place
Posted by "Martin Kočí (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031929#comment-13031929 ]
Martin Kočí commented on MYFACES-3134:
--------------------------------------
I think that suspicious lines:
if (log.isLoggable(Level.FINEST)) log.finest("Calling saveView of StateManagementStrategy from getViewState: "+sms.getClass().getName());
return facesContext.getRenderKit().getResponseStateManager().getViewState(facesContext, saveView(facesContext));
in org.apache.myfaces.application.jsp.JspStateManagerImpl.getViewState(FacesContext), line 617
breaks PPS - there must be
if (sms != null)
{
savedState = (Object[]) sms.saveView(facesContext);
}
> Move all code related to state caching into one place
> -----------------------------------------------------
>
> Key: MYFACES-3134
> URL: https://issues.apache.org/jira/browse/MYFACES-3134
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.6, 2.1.0
>
> Attachments: MYFACES-3134-2.patch
>
>
> It is necessary to do some cleanup and add more junit tests to state saving code in MyFaces.
> For PSS code, we just copied some parts of the original algorithm found on JspStateManagerImpl because just PSS was a very challenging task and the intention was prevent break existing code.
> But now we have a stable code in this part, so it is the right moment to do some cleanup and then change the code to fit user's needs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3134) Move all code related to state
caching into one place
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031963#comment-13031963 ]
Leonardo Uribe commented on MYFACES-3134:
-----------------------------------------
Note JspStateManagerImpl will be replaced by org.apache.myfaces.application.StateManagerImpl. There are some changes to do in this part, but the details will be discussed on myfaces dev list.
> Move all code related to state caching into one place
> -----------------------------------------------------
>
> Key: MYFACES-3134
> URL: https://issues.apache.org/jira/browse/MYFACES-3134
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.6, 2.1.0
>
> Attachments: MYFACES-3134-2.patch
>
>
> It is necessary to do some cleanup and add more junit tests to state saving code in MyFaces.
> For PSS code, we just copied some parts of the original algorithm found on JspStateManagerImpl because just PSS was a very challenging task and the intention was prevent break existing code.
> But now we have a stable code in this part, so it is the right moment to do some cleanup and then change the code to fit user's needs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira