[GitHub] [lucene-solr] dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

[GitBox <gi...@apache.org>]

dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness
URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519303495
 
 
   Thanks for the PR!  Just curious; did you encounter this problem and thus were motivated to fix it?  
   
   I didn't spend much time on it tonight, but it looks pretty good, and it has a cleaner appearance that reads better to me.  You did remove a comment or two that are still appropriate, like the link to Z-order.  Did you run Lucene spatial-extras tests?  "ant precommit"?
   
   I suspect a tokenization change ought to be toggled by Version, similar to some other behavior changes in Lucene analyzers.  And that means finding a way for the old tokenization and the new-one to co-exist, plus a means to communicate that choice -- probably via `org.apache.lucene.spatial.prefix.tree.SpatialPrefixTreeFactory#init`.  If we don't do this, then some use-cases with existing indexes may break, like exact point lookup of itself should round-trip.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org